From: Eli Zaretskii <eliz@gnu.org>
To: Andrea Corallo <akrl@sdf.org>
Cc: larsi@gnus.org, 48029@debbugs.gnu.org, jakanakaevangeli@chiru.no
Subject: bug#48029: 28.1; [native-comp] Function names with non-ascii characters
Date: Fri, 08 Jul 2022 15:40:35 +0300 [thread overview]
Message-ID: <838rp34w1o.fsf@gnu.org> (raw)
In-Reply-To: <xjf1quwq995.fsf@ma.sdf.org> (message from Andrea Corallo on Fri, 08 Jul 2022 08:49:42 +0000)
> From: Andrea Corallo <akrl@sdf.org>
> Cc: larsi@gnus.org, 48029@debbugs.gnu.org, jakanakaevangeli@chiru.no
> Date: Fri, 08 Jul 2022 08:49:42 +0000
>
> > Why do we have ";; -*-coding: nil; -*- "? I think that's the problem:
> > it should be ";; -*-coding: utf-8; -*- " instead. Where does the nil
> > come from?
>
> AFAIR at the time we encountered a situation when one of these files was
> read back with some other encoding (I guess it's heuristic?) so fixing
> the encoding to nil solved the issue.
You mean, bug#45433? If the problem is EOL conversion, using
utf-8-unix instead of utf-8 should take care of that. Or maybe even
use utf-8-emacs-unix.
Are we likely to write bytecode into this temporary file?
> > Lisp sources are by default UTF-8 encoded, so that should be the
> > default for the temp file we write. Bonus points for using the actual
> > encoding of the Lisp source file there (which in very rare cases can
> > be something other than UTF-8).
>
> Ok attached the patch that sets it to utf-8, seems to work for me.
>
> I'll have a look on how to spill the original coding system and get the
> bonus points hopefully next week.
Thanks.
> Should this patch go in master or into the release branch?
To the release branch, if Lars agrees. But let's first try to see if
bug#45433 is not back after the above change.
next prev parent reply other threads:[~2022-07-08 12:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 8:53 bug#48029: 28.1; [native-comp] Function names with non-ascii characters jakanakaevangeli
2021-05-02 8:47 ` Lars Ingebrigtsen
2021-05-02 21:19 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-30 13:10 ` Lars Ingebrigtsen
2022-07-04 8:51 ` Andrea Corallo
2022-07-04 11:20 ` Eli Zaretskii
2022-07-07 8:58 ` Andrea Corallo
2022-07-07 17:47 ` Lars Ingebrigtsen
2022-07-07 20:51 ` Andrea Corallo
2022-07-08 5:43 ` Eli Zaretskii
2022-07-08 8:49 ` Andrea Corallo
2022-07-08 12:40 ` Eli Zaretskii [this message]
2022-07-08 13:43 ` Andrea Corallo
2022-07-08 13:59 ` Eli Zaretskii
2022-07-08 14:53 ` Andrea Corallo
2022-07-10 12:56 ` Lars Ingebrigtsen
2022-07-10 13:02 ` Eli Zaretskii
2022-07-12 14:24 ` Andrea Corallo
2022-07-12 15:40 ` Eli Zaretskii
2022-07-12 15:46 ` Lars Ingebrigtsen
2022-07-13 13:20 ` Andrea Corallo
2023-06-05 8:50 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838rp34w1o.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=48029@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=jakanakaevangeli@chiru.no \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).