unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 57152@debbugs.gnu.org
Subject: bug#57152: 29.0.50; Emacs executable isn't rebuilt when loaddefs.el is modified
Date: Mon, 15 Aug 2022 14:58:07 +0300	[thread overview]
Message-ID: <838rnpiur4.fsf@gnu.org> (raw)
In-Reply-To: <87a685akh8.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon,  15 Aug 2022 12:07:15 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 57152@debbugs.gnu.org
> Date: Mon, 15 Aug 2022 12:07:15 +0200
> 
> I've tried various things, like making autoloads an order-only
> prerequisite for $(pdmp) (and various other targets), but the main
> problem seems to be that Make has already computed the
> timestamps/dependencies at this point, so even if we're running the
> update at the "right" time, we don't trigger the $(pdmp) rule.

That cannot be the reason, AFAIK.  Make begins by reading all the
rules and dependencies in the Makefile and producing a DAG for
rebuilding the targets; then it walks the DAG invoking commands as it
goes.  Thus, a target that is going to be rebuilt will automatically
trigger the rules of all the targets that depend on it, as long as the
dependencies are known to Make in full.

IOW, Make doesn't update the timestamps of files during the build, it
figures it all out in advance.

So I think the problem here is that the rules which trigger
regeneration of loaddefs.el are in lisp/Makefile, while the rules for
building $(pdmp) are in src/Makefile.

So maybe moving or duplicating the loaddefs.el rules in src/Makefile
will do the trick.





  reply	other threads:[~2022-08-15 11:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12  7:03 bug#57152: 29.0.50; Emacs executable isn't rebuilt when loaddefs.el is modified Eli Zaretskii
2022-08-12 15:14 ` Lars Ingebrigtsen
2022-08-12 15:29   ` Eli Zaretskii
2022-08-13 11:42     ` Lars Ingebrigtsen
2022-08-15 10:07       ` Lars Ingebrigtsen
2022-08-15 11:58         ` Eli Zaretskii [this message]
2022-08-15 13:32           ` Gerd Möllmann
2022-08-17 10:40             ` Lars Ingebrigtsen
2022-08-17 13:50               ` Gerd Möllmann
2022-08-18 12:46                 ` Lars Ingebrigtsen
2022-08-19  9:24                   ` Gerd Möllmann
2022-08-17 10:34           ` Lars Ingebrigtsen
2022-08-17 12:08             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838rnpiur4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=57152@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).