From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 57876@debbugs.gnu.org, public@protesilaos.com, arstoffel@gmail.com
Subject: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line
Date: Sun, 18 Sep 2022 15:55:48 +0300 [thread overview]
Message-ID: <838rmgzvsb.fsf@gnu.org> (raw)
In-Reply-To: <87o7vc26mq.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 18 Sep 2022 14:45:33 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: arstoffel@gmail.com, public@protesilaos.com, 57876@debbugs.gnu.org
> Date: Sun, 18 Sep 2022 14:45:33 +0200
>
> Oh, sorry! I was confusing myself by testing with
>
> (let ((inhibit-point-motion-hooks t)) (beginning-of-visual-line))
>
> which is the wrong thing, of course -- with inhibit-field-text-motion it
> works fine.
>
> So adjusting the patch to use that instead might be appropriate (but
> doesn't make much difference).
My point in suggesting that was that it is better to use utility
functions we have rather than the equivalent code, because the utility
functions presumably serve as a locus of all our wisdom related to
what they do. For example, what does "beginning of visual line" mean
with bidirectional text? Instead of having to decide this in each
case, we have a function that already does TRT.
prev parent reply other threads:[~2022-09-18 12:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 8:23 bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line Augusto Stoffel
2022-09-17 9:38 ` Eli Zaretskii
2022-09-17 10:56 ` Augusto Stoffel
2022-09-17 11:20 ` Eli Zaretskii
2022-09-17 11:31 ` Augusto Stoffel
2022-09-17 11:49 ` Eli Zaretskii
2022-09-18 7:23 ` Protesilaos Stavrou
2022-09-18 11:02 ` Lars Ingebrigtsen
2022-09-18 12:40 ` Eli Zaretskii
2022-09-18 12:45 ` Lars Ingebrigtsen
2022-09-18 12:55 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838rmgzvsb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=57876@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=larsi@gnus.org \
--cc=public@protesilaos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).