From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58708: 29.0.50; [PATCH] Fix build error that gflags.will_dump_ not surround by the directives as its definition Date: Sat, 22 Oct 2022 10:00:09 +0300 Message-ID: <838rl8uyva.fsf@gnu.org> References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26391"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58708@debbugs.gnu.org To: lin Sun Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 22 09:09:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1om8dE-0006i1-IV for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Oct 2022 09:09:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1om8Vh-0004qM-VY; Sat, 22 Oct 2022 03:01:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om8VD-0004mK-4g for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 03:01:15 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1om8VC-0004CO-Dz for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 03:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1om8VC-0000zJ-3a for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 03:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Oct 2022 07:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58708 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16664220173719 (code B ref -1); Sat, 22 Oct 2022 07:01:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Oct 2022 07:00:17 +0000 Original-Received: from localhost ([127.0.0.1]:39608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1om8UT-0000xt-EL for submit@debbugs.gnu.org; Sat, 22 Oct 2022 03:00:17 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:51322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1om8UR-0000xj-PO for submit@debbugs.gnu.org; Sat, 22 Oct 2022 03:00:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om8UL-0004a6-Og for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 03:00:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om8UL-00041H-G6; Sat, 22 Oct 2022 03:00:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Cmtj9JK2XM8dqFQ2mUF59A3J/QrorfO2ltLBZZR0kqU=; b=XNQPs3Ib5Moz YrGAgEM53SpEXD5dldA1uxO6BWOOVe8CTmjdnzlW3m6T4N9u/1D+X6BU7sMgeHS6d7nEV7kp80inm yBtk6j9xHugFB6BGZA192nQSVj/mCdKAzBaBZi7W5M1g7V5k0DkG8aKfrNPrOFU7IisQosBaYFW+V vtop89ZAb4pP0ZM+mzzZxC4KbCFMKfGhlAGk8LPjFcS3+9UhhymvuZdbGIDzQHsHuhBliqsEdVJMa K9B/mbw6t0x0OeCzpP8KHHQqLM3nlm+NrlUNic5JI0eASHCm1lMGnjstnTAHnEMghJMtJsGi+6pQe wk62NSe/DEODkuP/IKlONQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om8UK-0007Eh-TK; Sat, 22 Oct 2022 03:00:09 -0400 In-Reply-To: (message from lin Sun on Sat, 22 Oct 2022 05:16:45 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246025 Archived-At: > From: lin Sun > Date: Sat, 22 Oct 2022 05:16:45 +0000 > > The "gflags.will_dump_" is defined in the lisp.h and surround by these > directives, > > #if defined HAVE_PDUMPER || defined HAVE_UNEXEC > > bool will_dump_ : 1; > > #endif > > But its references weren't surrounded with the same directives, so > emacs will fail to build without any dumper. > > This patch will fix the build errors. Please review and merge this patch. Thanks Thanks, but I prefer to have this field to be defined unconditionally. That's a much simpler, cleaner change, and the fact that it "wastes" a one-bit field in some builds is nothing to worry about, IMO.