From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists Date: Thu, 24 Nov 2022 19:02:04 +0200 Message-ID: <838rk0wak3.fsf@gnu.org> References: <87wn7ujpdh.fsf@web.de> <83edtz84wl.fsf@gnu.org> <87pmdctsf8.fsf@web.de> <83edtswi35.fsf@gnu.org> <87fse8tona.fsf@web.de> <83cz9cwg5z.fsf@gnu.org> <87bkowtmmr.fsf@web.de> <83a64gwfhv.fsf@gnu.org> <877czktlvr.fsf@web.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15940"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, jonas@bernoul.li, 59328@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 24 18:02:46 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyFcc-0003wa-AV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Nov 2022 18:02:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyFbw-0001kL-Ds; Thu, 24 Nov 2022 12:02:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyFbu-0001hS-Pe for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 12:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyFbu-0008AH-Ce for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 12:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyFbu-0004jh-8A for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 12:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 17:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59328 X-GNU-PR-Package: emacs Original-Received: via spool by 59328-submit@debbugs.gnu.org id=B59328.166930931618193 (code B ref 59328); Thu, 24 Nov 2022 17:02:02 +0000 Original-Received: (at 59328) by debbugs.gnu.org; 24 Nov 2022 17:01:56 +0000 Original-Received: from localhost ([127.0.0.1]:59932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyFbo-0004jN-9Y for submit@debbugs.gnu.org; Thu, 24 Nov 2022 12:01:56 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyFbm-0004jA-1D for 59328@debbugs.gnu.org; Thu, 24 Nov 2022 12:01:55 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyFbf-00087d-Pz; Thu, 24 Nov 2022 12:01:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CFlGJrNqugad19m6r/hL2TtvIQqtSV0MjgKKYsGZT1w=; b=ch6GyK/6g9DD 5NMjyyNBl7U8U7G9pvz87glJRULJgNMHoXAAKYVhN1TX+3Z/77gSf+nHUnQm8XTRdEnY8qB5K3CNv PpDBcGFLr5ttshrQ0Zxm5v0Dz9AP5/KNmAHtXRPedj86OoZZFW/Cemxho9vohHIhYNLah0lpb5Nhm hIuizeeJmP5f1C0OUfZFlw6RGbPWd/MbbgIUZCcgffrCTb0imMm9+fHhZhGMgoYXXg6xv82IeXNx5 5fEMa3Yz6EtLye/JJKu392kAKIchwekEOzskIpIVYlPTWzmyyb/0DFUEInljQM+xRrcDO7imTePnp 8Bjx3TKI3oRGX96yHjKalQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyFbc-0003hF-Oc; Thu, 24 Nov 2022 12:01:47 -0500 In-Reply-To: <877czktlvr.fsf@web.de> (message from Michael Heerdegen on Thu, 24 Nov 2022 16:25:44 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248882 Archived-At: > From: Michael Heerdegen > Cc: 59328@debbugs.gnu.org, larsi@gnus.org, jonas@bernoul.li > Date: Thu, 24 Nov 2022 16:25:44 +0100 > > Eli Zaretskii writes: > > > > Without that change `seq-keep' would error for sequence types like > > > streams. Try for example > > > > > > #+begin_src emacs-lisp > > > (require 'stream) > > > (seq-keep > > > (lambda (x) (and (<= 0 x) x)) > > > (stream (list -1 2 -3 4))) > > > #+end_src > > > > Didn't you just say that 'stream' is not in Emacs? If I try the above, the > > debugger kicks in right on the 'require' line. > > Yes. > > But seq-keep is not a generic function, so it would be broken for > sequence types defined elsewhere, and there is no way for those other > sequence types to fix this. Defining a generic interface for sequences > would not make much sense if it then only supports lists (and maybe > vectors). > > So we want to support cases like streams. Can tests for this be written in a way that they are only run if the relevant packages are available on the user's system? If so, I'd prefer to have that than no tests at all. Your call. Thanks.