From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59498: 29.0.50; c++-ts-mode get wrong-type-argument error when enabled Date: Sat, 26 Nov 2022 13:18:01 +0200 Message-ID: <838rjyt15i.fsf@gnu.org> References: <6_5zC6qq_eQV2whwZ7epZMUlEN-yk5iOlJBLuVnNDLzl4RUGCPFnbIN12pG-DyNvCAYlRJTTopEe_RxX2_B7nSJQyBCJrzo915uBA51qW8A=@rjt.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29330"; mail-complaints-to="usenet@ciao.gmane.io" Cc: aqua0210@foxmail.com, 59498@debbugs.gnu.org, mardani29@yahoo.es To: Randy Taylor , Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 26 12:18:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oytCP-0007Q1-C9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Nov 2022 12:18:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oytC9-0002rU-GK; Sat, 26 Nov 2022 06:18:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oytC7-0002rI-NU for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 06:18:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oytC7-0001E0-44 for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 06:18:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oytC5-0005iz-Sx for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 06:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 11:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59498 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59498-submit@debbugs.gnu.org id=B59498.166946147821995 (code B ref 59498); Sat, 26 Nov 2022 11:18:01 +0000 Original-Received: (at 59498) by debbugs.gnu.org; 26 Nov 2022 11:17:58 +0000 Original-Received: from localhost ([127.0.0.1]:37987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oytC1-0005ih-Jx for submit@debbugs.gnu.org; Sat, 26 Nov 2022 06:17:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oytBy-0005iR-Jz for 59498@debbugs.gnu.org; Sat, 26 Nov 2022 06:17:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oytBp-0001Bb-Dx; Sat, 26 Nov 2022 06:17:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=zNy7mi1yOZqRnCPL1H/MGt7doMR43z68GHWLQ3CUsMc=; b=rBKFHpCNjOXNjresJucC lp+6xkWaeKHPdotrUQm8w+WWRbdiQ9US2ACO5oV1R+4eqBez7vxEq9ZMlU2j8dmAJPyFXQb1iNl3c fIO8H9BjMPdkmIr3CfXYIrvckq8eU36Dt4JbEU3wjIuR2HfWY0DrbtM4d+N+4y9gsMMoaNbR/woSD ctgsD+FpD3448PGhgp2E41iI+HDwXltAWfBYIFPtN8HyRCrb+ZBruoj6FPnvFh43gbJyUGvitGsv5 /6GoQIXimGUvocWReLtckz+18Z2my+jiSU4XU2hs8TJ/mfAhW9geK8qUPLKzvz+QrqGORm0CiXsob fLJqkq35bbEx+Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oytBl-0004Is-TD; Sat, 26 Nov 2022 06:17:43 -0500 In-Reply-To: <6_5zC6qq_eQV2whwZ7epZMUlEN-yk5iOlJBLuVnNDLzl4RUGCPFnbIN12pG-DyNvCAYlRJTTopEe_RxX2_B7nSJQyBCJrzo915uBA51qW8A=@rjt.dev> (message from Randy Taylor on Thu, 24 Nov 2022 14:39:19 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249073 Archived-At: > Cc: Yuan Fu , 59498@debbugs.gnu.org, > Daniel Martín > Date: Thu, 24 Nov 2022 14:39:19 +0000 > From: Randy Taylor > > diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el > index fc35d9aedda..48f504214e2 100644 > --- a/lisp/progmodes/c-ts-mode.el > +++ b/lisp/progmodes/c-ts-mode.el > @@ -570,6 +570,8 @@ c++-ts-mode > (setq-local comment-start "// ") > (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") > (setq-local comment-end "") > + (setq-local treesit-comment-start (rx "/" (or (+ "/") (+ "*")))) > + (setq-local treesit-comment-end (rx (+ (or "*")) "/")) > > (treesit-parser-create 'cpp) Thanks, but this doesn't look right to me: why should c++-ts-mode set variables for treesit.el? It is more likely that treesit.el should use the buffer-local values of comment-start and comment-end instead, and fall back on generic values (if they make sense) only if the local values are not set. Yuan, WDYT?