From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60001: [PATCH] Improve completion of treesit-check-indent command Date: Mon, 12 Dec 2022 16:00:24 +0200 Message-ID: <838rjcsow7.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34737"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60001@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 15:12:02 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4jXF-0008p0-Ik for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 15:12:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4jMi-0001hY-JF; Mon, 12 Dec 2022 09:01:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4jMc-0001dB-PB for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 09:01:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4jMc-0000Zd-H2 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 09:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4jMc-0007Cm-2N for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 09:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 14:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60001 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60001-submit@debbugs.gnu.org id=B60001.167085363327682 (code B ref 60001); Mon, 12 Dec 2022 14:01:02 +0000 Original-Received: (at 60001) by debbugs.gnu.org; 12 Dec 2022 14:00:33 +0000 Original-Received: from localhost ([127.0.0.1]:53123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4jM8-0007CQ-RY for submit@debbugs.gnu.org; Mon, 12 Dec 2022 09:00:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4jM7-0007CI-6i for 60001@debbugs.gnu.org; Mon, 12 Dec 2022 09:00:31 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4jM0-0000Im-TP; Mon, 12 Dec 2022 09:00:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=n0/vs1PY0xzjlwaFwoshadFXTJqCae69OquRCP6NNsI=; b=m7zsfOfEZ7dQDFHn+em8 1ATKemPRG/Q/y/E6gHlpwdurdizKEoOIGUh/OJcDbtqnEShUngw8Dqtj/yxw4FiMuzwGUFjo8WOCY XAE5ahMpaB5bzrrIIel/R+2pZWnNbVCPaE+7BiwKSphhiJnzsa+wuh5ZFuz8FTj6e7OXMjyOUB6vP 0w8G6O0NQ+Qbn4kN0I13F+AUdVZg7TXt0aYSkXjF03FLFtfKhohsaxnvHmI2ouz31j5GH6tRYJfyV brD4CoLeCD/mxdGnjlZm0lLGdX5AnXSFd3BooSFr/XvVPTOg2qNwAjrlmFS0HKzc3iXWfMymobNDG W9o+5pi8qQSXMw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4jLy-00082N-Rm; Mon, 12 Dec 2022 09:00:23 -0500 In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250705 Archived-At: > Date: Mon, 12 Dec 2022 11:53:00 +0100 > From: Daniel Martín via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > The treesit-check-indent command is not really related to Tree-sitter > and could be in a more general place than treesit.el. WDYT? I agree, but then we'd need a definition for it that doesn't need tree-sitter support. Is that easy to provide? > In any case, I have a patch to improve this command a bit by offering > more accurate completion for major modes, not Emacs commands. I have > also tried to improve its documentation a bit. How about a read-major-mode function in subr.el? But I think all these generalizations and improvements should go to master. On the release branch, I'd prefer to leave treesit-check-indent alone.