unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 60569@debbugs.gnu.org
Subject: bug#60569: 29.0.60; vc-pull-and-push unsupported on non-git vcs
Date: Mon, 23 Jan 2023 14:00:34 +0200	[thread overview]
Message-ID: <838rhtjw9p.fsf@gnu.org> (raw)
In-Reply-To: <86edrm4gyk.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 22 Jan 2023 19:28:03 +0200)

> From: Juri Linkov <juri@linkov.net>
> Date: Sun, 22 Jan 2023 19:28:03 +0200
> 
> > Thanks for keeping VC generic.
> 
> Here is a one-line patch that adds support for vc-bzr.
> 
> Eli, is it ok to install this on the emacs-29 branch?
> I briefly tested it on bzr, so it should be quite safe.
> 
> diff --git a/lisp/vc/vc-bzr.el b/lisp/vc/vc-bzr.el
> index 6443f6d57aa..404800cb208 100644
> --- a/lisp/vc/vc-bzr.el
> +++ b/lisp/vc/vc-bzr.el
> @@ -381,7 +381,8 @@ vc-bzr--pushpull
>            (setq-local compile-command
>                        (concat vc-bzr-program " " command " "
>                                (if args (mapconcat #'identity args " ") "")))))
> -      (vc-set-async-update buf))))
> +      (vc-set-async-update buf)
> +      (get-buffer-process buf))))

Looks OK to me, but could you add some details regarding why this
change is needed?  Did we change our requirements from the return
value of the pushpull method?  Or did vc-set-async-update change its
behavior and no longer returns the process object?  Or something else?

Thanks.





  reply	other threads:[~2023-01-23 12:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-05  7:58 bug#60569: 29.0.60; vc-pull-and-push unsupported on non-git vcs Juri Linkov
2023-01-18 17:39 ` Juri Linkov
2023-01-20  4:02   ` Richard Stallman
2023-01-22 17:28     ` Juri Linkov
2023-01-23 12:00       ` Eli Zaretskii [this message]
2023-01-24 17:49         ` Juri Linkov
2023-01-24 18:08           ` Eli Zaretskii
2023-01-24 18:29             ` Juri Linkov
2023-01-22  2:25   ` Dmitry Gutov
2023-01-22 17:27     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838rhtjw9p.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=60569@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).