From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62858: 30.0.50; Typo in gdb-mi.el Date: Sat, 15 Apr 2023 17:14:47 +0300 Message-ID: <838retcjvs.fsf@gnu.org> References: <87ttxhs2x0.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34597"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62858@debbugs.gnu.org To: Manuel Giraud , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 15 16:15:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnggV-0008mx-6D for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Apr 2023 16:15:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnggD-000412-FV; Sat, 15 Apr 2023 10:15:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnggB-00040e-4c for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 10:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pnggA-0007re-SJ for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 10:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pnggA-00020H-G6 for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 10:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Apr 2023 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62858 X-GNU-PR-Package: emacs Original-Received: via spool by 62858-submit@debbugs.gnu.org id=B62858.16815680977670 (code B ref 62858); Sat, 15 Apr 2023 14:15:02 +0000 Original-Received: (at 62858) by debbugs.gnu.org; 15 Apr 2023 14:14:57 +0000 Original-Received: from localhost ([127.0.0.1]:49933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pngg4-0001ze-8m for submit@debbugs.gnu.org; Sat, 15 Apr 2023 10:14:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pngg2-0001zS-CT for 62858@debbugs.gnu.org; Sat, 15 Apr 2023 10:14:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pngfw-0007oD-09; Sat, 15 Apr 2023 10:14:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xuGsPQjre3tUCYBnnNHum2SRU+V0oKy9KUt53IeqMzo=; b=RR8volp2SiB0 lDiWNmzw19kYk+Vnw6MNMhuNuA48UrQOVLeOF99N4Ea6W10DC/EIs3Q2bywRfi2AjwAuLSCjxojHk cvTt+8YV04KSpypF0c/mldDbTrrkuvaqdv/mRi52Yn8a0oCYvaoXQ/YtjO9sfbaJMjGwaTh4MImsa 3B4bLaSkj7E/+7Mben3tBRdLH6hwNTAW9+hz1kwcTI7FQCyoB13JrQ8r87GK50ioN+kG1m5RveHlY 9IiKEzYrOkOtwT54MT2LzhEgHsuo2+SZ2jci8vCKIGA6b0pUMml1aVGL+UbH86i+E2mh3HFVGBZyh 4NHS6ivWXYDlpRxUqBqLjQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pngfv-0000z4-BF; Sat, 15 Apr 2023 10:14:47 -0400 In-Reply-To: <87ttxhs2x0.fsf@ledu-giraud.fr> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260058 Archived-At: > Date: Sat, 15 Apr 2023 15:14:35 +0200 > From: Manuel Giraud via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I do not think that it generates a bug but while browsing "gdb-mi.el", I > noticed the following at line 2409: > --8<---------------cut here---------------start------------->8--- > ("=" . (("thread-created" . (gdb-thread-created . atomic)) > ("thread-selected" . (gdb-thread-selected . atomic)) > ("thread-existed" . (gdb-ignored-notification . atomic)) > --8<---------------cut here---------------end--------------->8--- > > Should it not be "thread-exited"? There is no reference to > "thread-existed" in the GDB info. You are right. But I think the snafu here is even more than just a typo. This code was introduced in commit 6ff2c8f1f, where Stefan (CC'ed) took a patch by Jean-Philippe Gravel and improved it. But as part of that change, Stefan made this typo, and also made gdb-thread-exited a function that no one calls, which was not what happened with the original code. So I think we need to fix that with the patch below. Stefan, any comments? diff --git a/lisp/progmodes/gdb-mi.el b/lisp/progmodes/gdb-mi.el index 8db1672..27f04e0 100644 --- a/lisp/progmodes/gdb-mi.el +++ b/lisp/progmodes/gdb-mi.el @@ -2406,7 +2406,7 @@ gdbmi-bnf-result-state-configs ("+" . ()) ("=" . (("thread-created" . (gdb-thread-created . atomic)) ("thread-selected" . (gdb-thread-selected . atomic)) - ("thread-existed" . (gdb-ignored-notification . atomic)) + ("thread-exited" . (gdb-thread-exited . atomic)) ('default . (gdb-ignored-notification . atomic))))) "Alist of alists, mapping the type and class of message to a handler function. Handler functions are all flagged as either `progressive' or `atomic'.