From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60418: [PATCH] Add :vc keyword to use-package Date: Thu, 04 May 2023 13:39:29 +0300 Message-ID: <838re4l6se.fsf@gnu.org> References: <87zgb6uk2r.fsf@hyperspace> <87y1n3zsro.fsf@posteo.net> <871qku220f.fsf@betli.tmit.bme.hu> <874jpq920b.fsf@posteo.net> <87cz4ezpwi.fsf@betli.tmit.bme.hu> <87h6tlinft.fsf@hyperspace> <87r0spa712.fsf@posteo.net> <87edopiif5.fsf@hyperspace> <87wn2bzvcp.fsf@hyperspace> <835y9vbyfr.fsf@gnu.org> <87mt36uwl8.fsf@hyperspace> <83ttxd8k1z.fsf@gnu.org> <87v8hrn56l.fsf@hyperspace> <87cz3w2lvb.fsf@posteo.net> <87jzy3ku6u.fsf@hyperspace> <87bkje93ou.fsf@posteo.net> <87y1mhihhy.fsf@hyperspace> <87ildbet2d.fsf@hyperspace> <831qjyoqj5.fsf@gnu.org> <87h6suolt2.fsf@hyperspace> <83ttwun4q4.fsf@gnu.org> <87o7n0fr9e.fsf@hyperspace> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2661"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, felician.nemeth@gmail.com, 60418@debbugs.gnu.org, stefankangas@gmail.com To: Tony Zorman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 04 12:39:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puWMo-0000Nz-FX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 May 2023 12:39:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puWMg-00073c-JT; Thu, 04 May 2023 06:39:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puWMd-00070S-Kh for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 06:39:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puWMY-00077I-Os for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 06:39:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puWMY-0004kL-AO for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 06:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 May 2023 10:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60418-submit@debbugs.gnu.org id=B60418.168319673618231 (code B ref 60418); Thu, 04 May 2023 10:39:02 +0000 Original-Received: (at 60418) by debbugs.gnu.org; 4 May 2023 10:38:56 +0000 Original-Received: from localhost ([127.0.0.1]:48635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puWMS-0004jz-4S for submit@debbugs.gnu.org; Thu, 04 May 2023 06:38:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puWML-0004jf-DT for 60418@debbugs.gnu.org; Thu, 04 May 2023 06:38:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puWMC-0006oa-Ea; Thu, 04 May 2023 06:38:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TtVMwiB90/cNRHZeg1qH6vlUiNDS64pFNm/MIqU27TI=; b=hQDG2qDDyBdL RYtbloslRN/KB+hk0kWR8ED9WlvzAr6ZKGk3qGKoXWLW5bX0hycc2zdjDpPaK+zbkR/aRh1O2OuSy 9IAY6FoBKnktRvUp6i3ZVDOOP8wuFyA9yjIu04Q1/ivdDX7HXtO9EMmT/HW5n/DVEwp9QG8r2nYng i03CAjNzCTwSAqK4Yg89OoP61JfZkwwk9oXIures0EDFUpvIYxPDsmQoJ+8EfmsXoiyHV6QpZgGLe T1as4IV4C5y2x6VXfJNcasNXlttkfaQzdEEEOxn5AlJVwjQsWwq3lGEj/YNlMaSpfzX4Woe8J0D3s yovKgPj1JbgvmklpNIjnzw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puWMB-000280-Uu; Thu, 04 May 2023 06:38:40 -0400 In-Reply-To: <87o7n0fr9e.fsf@hyperspace> (message from Tony Zorman on Thu, 04 May 2023 10:13:49 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261009 Archived-At: > From: Tony Zorman > Cc: philipk@posteo.net, 60418@debbugs.gnu.org, felician.nemeth@gmail.com, > stefankangas@gmail.com > Date: Thu, 04 May 2023 10:13:49 +0200 > > > Not in my eyes, it isn't. E.g., look at any GitHub repository: there > > are "commits" there, and there are "releases", and they are not the > > same. > > You're right, but I don't think I'm using them as synonyms. There is a > big difference between > > (package-vc-install "foo") > > which installs the latest "commit" (or revision, which I'm actually > using as a synonym to commit) of a package, and > > (package-vc-install "foo" :last-release) > > which installs the latest "release". A release, as defined by > package-vc.el seems to be 'the latest revision that bumps the "Version" > tag.' It is queried in the package-vc--release-rev function, and > actually retrieved in vc-retrieve-tag. The "Version" tag is, I think, > just the "Version: XXX" string that's specified in the top comment of > the main elisp file of the respective repository. OK, then this should be documented. Specifically, it is important to explain that the default is the latest _commit_ (a.k.a. HEAD) of the default branch, whereas specific releases are those that bump the Version: tag in the main ELisp file. > > Are you talking about commits? More generally, what kind of "release > > IDs" does :rev accept as its valid value? > > The :rev keyword accepts the same as REV of package-vc-install, which is > either > > - nil, signaling that the latest commit should be installed, > > - :last-release, signaling that the last release should be installed, > or > > - a "version string" appropriate for the respective version control > system, specifying that version (e.g., a specific commit hash). Any value other than a commit hash? E.g., are tags supported? And how will the user know which commit hash or tag to specify given the value of a Version: tag in the main file? We should document that as well. Thanks.