From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63253: 29.0.90; with-delayed-message fails in combination with inhibit-message Date: Wed, 10 May 2023 14:16:36 +0300 Message-ID: <838rdwa12j.fsf@gnu.org> References: <87r0rxdwc8.fsf@daniel-mendler.de> <837ctidgab.fsf@gnu.org> <831qjqdcz9.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1276"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mail@daniel-mendler.de, larsi@gnus.org, 63253@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 10 13:33:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwi4d-00009D-NG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 May 2023 13:33:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwhnk-0004o6-5w; Wed, 10 May 2023 07:16:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwhnh-0004nj-8W for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 07:16:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwhne-0001r8-I8 for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 07:16:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwhne-0007Z3-6W for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 07:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 May 2023 11:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63253 X-GNU-PR-Package: emacs Original-Received: via spool by 63253-submit@debbugs.gnu.org id=B63253.168371735628890 (code B ref 63253); Wed, 10 May 2023 11:16:02 +0000 Original-Received: (at 63253) by debbugs.gnu.org; 10 May 2023 11:15:56 +0000 Original-Received: from localhost ([127.0.0.1]:45369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwhnY-0007Vj-AY for submit@debbugs.gnu.org; Wed, 10 May 2023 07:15:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwhnU-0007Ef-QO for 63253@debbugs.gnu.org; Wed, 10 May 2023 07:15:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwhnO-0001je-1s; Wed, 10 May 2023 07:15:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Rfa8FTrLd2170LklH6A0OwAoULTI0I7e1xuX7eBnn3w=; b=k5IWVzA3Ek/d Wt24xbRMg4KePOaLIu7ZgXulyIDGR8Fbh1s+pRvJA4aM/6N45VjVPeDfVY3q5crxhMfHst4h8HxiK h85inUTPrhKwgKtHzd893GYO3gKqzr3s5ys+1cEF2U2sFwEpT0Bog3vNcy1/d/ZleGF6RChNs99DP LvjyMmo4o7ZWkNso7KnAkPLmrtXzck7nDvTl337ztHNVn/56i1RvK3UT/H0bntfjIAEtM5UyCp6yU dmnaJQjdJ9MieyZ3K7sIjvC6W5lVjcMulOzYIXdSkdAZD+BsQEidk25ylHLd5LUHcruO4eylylwsM JlUDWo5hE1uxWlmSqz77KQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwhnM-0002aP-O8; Wed, 10 May 2023 07:15:45 -0400 In-Reply-To: (message from Stefan Monnier on Tue, 09 May 2023 22:31:09 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261484 Archived-At: > From: Stefan Monnier > Cc: Lars Ingebrigtsen , mail@daniel-mendler.de, > 63253@debbugs.gnu.org > Date: Tue, 09 May 2023 22:31:09 -0400 > > > Thanks, I think you should install this on the emacs-29 branch. And I > > think a similar change is needed in clear_message, so it doesn't call > > clear-message-function. > > OK, done. Thanks. > > But what does this mean for with-delayed-message and > > funcall-with-delayed-message? These were introduced in Emacs 29, but > > if we say that atimers cannot be used to safely run arbitrary Lisp, > > then we should somehow make them safer, perhaps by having in > > with_delayed_message_display a subset of code message3, without the > > calls to Lisp. WDYT? > > The code already falls back to a default behavior of displaying the > message in the echo area when calls to ELisp can't be used. You mean, the changes that you just installed? If so, that is AFAIU conditioned on garbage_collection_inhibited, which doesn't necessarily disable Lisp calls from delayed messages in all situations. Plus, we might at some point decide that garbage_collection_inhibited is not necessary in probably_quit. What I meant was to completely disable customizing set-message-function for delayed messages. We don't have to support that, and the fact that we call 'message' is just an implementation detail. If nothing else, this will make the effect on delayed messages consistent no matter when and how they are actually displayed.