From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63744: 28.2; fix dired-guess-default Date: Sat, 27 May 2023 09:49:31 +0300 Message-ID: <838rdajmkk.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29958"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63744@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 27 08:50:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2nky-0007Zd-Lz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 May 2023 08:50:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2nkd-0002o9-0D; Sat, 27 May 2023 02:50:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2nka-0002nu-NQ for bug-gnu-emacs@gnu.org; Sat, 27 May 2023 02:50:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2nkZ-00038Z-0y for bug-gnu-emacs@gnu.org; Sat, 27 May 2023 02:50:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2nkY-0003Tq-JU for bug-gnu-emacs@gnu.org; Sat, 27 May 2023 02:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 May 2023 06:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63744 X-GNU-PR-Package: emacs Original-Received: via spool by 63744-submit@debbugs.gnu.org id=B63744.168517014513286 (code B ref 63744); Sat, 27 May 2023 06:50:02 +0000 Original-Received: (at 63744) by debbugs.gnu.org; 27 May 2023 06:49:05 +0000 Original-Received: from localhost ([127.0.0.1]:51304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2njd-0003SE-5K for submit@debbugs.gnu.org; Sat, 27 May 2023 02:49:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2njb-0003Rk-5v for 63744@debbugs.gnu.org; Sat, 27 May 2023 02:49:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2njV-00031f-VQ; Sat, 27 May 2023 02:48:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sxYx4v265l+SQhxMxEKvJGINNMtrDtNveblamcYV3G4=; b=QsQQ4X10AqGT 90o/LmKZt6O9rKxKbt4zT2GRL4aOJzQvA1TEYp+EKJDDd1dyjni+g9rfLZ9Jmu8rmdXEAD78FaonW +85EyEgjho0nxmdYSwOqNTyBpdAQY1fu4pGU2YN/VDG0d5ta1lKPwYhYKXrtzhffIx9qwKCpZAI6p N5JRpUf3n+OQgeQ1fbrozFXHxiobahtj6pAyMSIiJwWZHgmBC7sIjwGZ74GFs88UqNF4cuf0XwBob 5WEJv1D/2EOftHSOjOnDby019lHH71Us955WZf2ma5RvI1S7Qs277h/Fp84glTL6WYg/Ljy0wXcAK q255yruByG7vy5MlOzebwQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2njV-0007Cv-Dn; Sat, 27 May 2023 02:48:57 -0400 In-Reply-To: (message from Leo Liu on Sat, 27 May 2023 12:10:15 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262466 Archived-At: > From: Leo Liu > Date: Sat, 27 May 2023 12:10:15 +0800 > > I have this customisation > > (setq dired-guess-shell-alist-user '(("." EXP))) > > where EXP evaluates to a list of strings. It has been working for ~10 > years until Emacs 28. What is the semantics of a list of strings in this case? shell-command takes a single string as its argument COMMAND, it doesn't take a list of strings. > After some digging it turns out there is a rewrite of > `dired-guess-default' which is not compatible. Previously returning a > list of strings from EXP accidentally worked. > > (eval (car cmds) `((file . ,file))) ; single command > > but if it evaluates to a list of strings it is perfectly fine as per the > documentation of dired-guess-default. I propose the following patch for > remedy. I'd rather not proliferate an undocumented "feature" that is merely a side effect of the particular implementation we had at some point, without understanding what it gives us. The alternative is for you to change your customization so that EXP returns the car of the list it returned before, and that should be both easy and backward-compatible, AFAIU.