From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63818: 27.1; unbound local variables break python-util-clone-local-variables Date: Sat, 03 Jun 2023 10:22:41 +0300 Message-ID: <838rd19fi6.fsf@gnu.org> References: <87leh4uqaj.fsf@debian-BULLSEYE-live-builder-AMD64> <83h6rrcsy6.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31610"; mail-complaints-to="usenet@ciao.gmane.io" Cc: erjoalgo@gmail.com, monnier@iro.umontreal.ca, 63818@debbugs.gnu.org To: kobarity Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 03 09:22:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5Lau-00085W-CP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Jun 2023 09:22:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5LaN-0007Lw-6q; Sat, 03 Jun 2023 03:22:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5LaM-0007Lj-Ak for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 03:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5LaM-0001w0-1k for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 03:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5LaL-0004GN-TM for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 03:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Jun 2023 07:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63818 X-GNU-PR-Package: emacs Original-Received: via spool by 63818-submit@debbugs.gnu.org id=B63818.168577691916376 (code B ref 63818); Sat, 03 Jun 2023 07:22:01 +0000 Original-Received: (at 63818) by debbugs.gnu.org; 3 Jun 2023 07:21:59 +0000 Original-Received: from localhost ([127.0.0.1]:41461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5LaI-0004G4-ME for submit@debbugs.gnu.org; Sat, 03 Jun 2023 03:21:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5LaG-0004Fq-JR for 63818@debbugs.gnu.org; Sat, 03 Jun 2023 03:21:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5LaA-0001v9-Vw; Sat, 03 Jun 2023 03:21:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bkPM/vf65ggFUYeAQ1UQU37Gx0ilJsMpC6khSvxHqL4=; b=DtGspXGKHxv/ /lzzn9yb4bXGAuUYqwC14e5Vx4sz3TwqGnt/x/OpzOo6HfY6QGyuErdKMi0raOy3/lKDiDk0uZmi/ ImldBuVuKZathsXd7ZGox9klMmWr3shOZWohLDn9yd4kCwlSamGeNtf4h/J+bp5uDFuX5e8LBYVaQ 2aRkRN3phwHikWtnuQ1PcK/m+Nb2r2Wxtm+22eYbJYs142VyeVW/ryw0tziSRZPsyvq4r+hSi6Tpw Ewzp4qDatJu73iuk9PtvlXHqL12Xw2Hf1+nXC3uNUWOIyMc2BQghJH75ZANWgYj0NSifUbY4HkrIL g8tKmZF8niq8FFrbyCTSyw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5LaA-0007BJ-Fy; Sat, 03 Jun 2023 03:21:50 -0400 In-Reply-To: (message from kobarity on Thu, 01 Jun 2023 23:36:24 +0900) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262805 Archived-At: > Date: Thu, 01 Jun 2023 23:36:24 +0900 > From: kobarity > Cc: Ernesto Alfonso , > Stefan Monnier , > 63818@debbugs.gnu.org > > > Stefan and kobarity, any comments? > > I'm not familiar with this area, but I looked at the Orgmode code. It > was changed to use pcase. > > (defun org-clone-local-variables (from-buffer &optional regexp) > "Clone local variables from FROM-BUFFER. > Optional argument REGEXP selects variables to clone." > (dolist (pair (buffer-local-variables from-buffer)) > (pcase pair > (`(,name . ,value) ;ignore unbound variables > (when (and (not (memq name org-unique-local-variables)) > (or (null regexp) (string-match-p regexp (symbol-name name)))) > (ignore-errors (set (make-local-variable name) value))))))) > > This change seems to be based on the following discussion. > > https://lists.gnu.org/archive/html/emacs-orgmode/2017-06/msg00037.html > > Maybe we can adopt the same approach? Our code is much simpler, so I don't see any need to use pcase here. Thanks.