From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64088: [PATCH] Make project-root for vc projects return an absolute path Date: Fri, 16 Jun 2023 08:52:40 +0300 Message-ID: <838rckt0lz.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33507"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64088@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 16 07:53:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qA2On-0008VZ-LG for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Jun 2023 07:53:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qA2OX-0001tY-SV; Fri, 16 Jun 2023 01:53:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qA2OM-0001t7-G7 for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2023 01:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qA2OM-0006gk-7q for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2023 01:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qA2OM-0006h8-4N for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2023 01:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Jun 2023 05:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64088 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64088-submit@debbugs.gnu.org id=B64088.168689474325682 (code B ref 64088); Fri, 16 Jun 2023 05:53:02 +0000 Original-Received: (at 64088) by debbugs.gnu.org; 16 Jun 2023 05:52:23 +0000 Original-Received: from localhost ([127.0.0.1]:48468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qA2Ni-0006g9-VF for submit@debbugs.gnu.org; Fri, 16 Jun 2023 01:52:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qA2Nh-0006ft-2W for 64088@debbugs.gnu.org; Fri, 16 Jun 2023 01:52:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qA2Nb-0006b9-Qx; Fri, 16 Jun 2023 01:52:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BGGyP+ZPpxfrlECh2ZRtrF/RQIhGgjn98Ybx7eGKK5s=; b=pZ3JNVHjmxEE loGS+Fcf8s/7gLmFtX5mVZ1hT/MkYO45vlQRDfWislvdqadnJ8H2zdoiq6V+xV0HrG/Fr7rdJzJoy VGaPdXRbZfBwcgstH+5X6IFQ1Y5Nm9dCf1U5eg4YR+7om5fSU5htaYWBm4QBCiLBLV7ryoW3zsftF L7oj79bgrRZCfIkBmgi6mGUP2s5O2BGRY0B+7hIVE1Mw90JdzP7vdBNfp2KnsO4OFTdwwB4SAkMF3 2MbkGkQ7r1RgIwWBiJIpyU76C3rVpdzsKMAsAIL29t5iHTnNx+sLf25RFSSmfEZUCZWrRKxqTgvQ2 +occCj31QRyRAWWQttYRiA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qA2Nb-0004Ve-AL; Fri, 16 Jun 2023 01:52:15 -0400 In-Reply-To: (message from Spencer Baugh on Thu, 15 Jun 2023 16:48:05 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263451 Archived-At: > From: Spencer Baugh > Date: Thu, 15 Jun 2023 16:48:05 -0400 > > Before this, if a vc project was in the user's home directory, > project-root would be "~/some/path". This violates the spec of > project-root, which requires an absolute path. File names like "~/some/file" are considered absolute in Emacs: (file-name-absolute-p "~/foo") => t > One concrete bug > caused by this is that (project-forget-project "~/some/path") would > work but (project-forget-project "/home/user/some/path") would not. That problem is simple to solve where it happens, no? That is, project-forget-project should try looking not just for the literal root, but also for its expanded and abbreviated forms, and that's all. > I ran into this while trying to use file-notify to automatically > discover and forget projects. file-notify returns truly absolute paths, > so I ran into the aforementioned concrete bug. And please do not use "path" when you mean file names. > >From 2c3ed85f857759458130a7b707d9b6f4d2c1ef20 Mon Sep 17 00:00:00 2001 > From: Spencer Baugh > Date: Thu, 15 Jun 2023 16:45:48 -0400 > Subject: [PATCH] Make project-root for vc projects return an absolute path > > Before this, if a vc project was in the user's home directory, > project-root would be "~/some/path". This violates the spec of > project-root, which requires an absolute path. One concrete bug > caused by this is that (project-forget-project "~/some/path") would > work but (project-forget-project "/home/user/some/path") would not. > > * lisp/progmodes/project.el (project-try-vc): Expand root directory > before returning project. > --- > lisp/progmodes/project.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index 2cffc1c0669..72cdb94bce4 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -689,7 +689,7 @@ project-try-vc > (let* ((parent (file-name-directory (directory-file-name root)))) > (setq root (vc-call-backend 'Git 'root parent)))) > (when root > - (setq project (list 'vc backend root)) > + (setq project (list 'vc backend (expand-file-name root))) > ;; FIXME: Cache for a shorter time. > (vc-file-setprop dir 'project-vc project) > project)))) I think this fixes a problem in the wrong place. It should be fixed where it happens, i.e. in project--remove-from-project-list. Thanks.