From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63967: 28.2; switch-to-buffer in normal window fails if minibuffer window is active Date: Sat, 17 Jun 2023 16:08:38 +0300 Message-ID: <838rciqlrd.fsf@gnu.org> References: <83fs701uts.fsf@gnu.org> <83a5x81m33.fsf@gnu.org> <83a5x6zj38.fsf@gnu.org> <83zg56xfyr.fsf@gnu.org> <83v8frursu.fsf@gnu.org> <83jzw6utnx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5542"; mail-complaints-to="usenet@ciao.gmane.io" Cc: al@petrofsky.org, 63967@debbugs.gnu.org, monnier@iro.umontreal.ca, acm@muc.de To: Alan Mackenzie , rudalics@gmx.at Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 17 15:09:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAVfz-0001GK-No for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Jun 2023 15:09:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAVft-0003jo-0Y; Sat, 17 Jun 2023 09:09:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAVfq-0003jQ-Ox for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2023 09:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qAVfq-000095-Gg for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2023 09:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qAVfq-0002RN-CT for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2023 09:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 13:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63967 X-GNU-PR-Package: emacs Original-Received: via spool by 63967-submit@debbugs.gnu.org id=B63967.16870073319365 (code B ref 63967); Sat, 17 Jun 2023 13:09:02 +0000 Original-Received: (at 63967) by debbugs.gnu.org; 17 Jun 2023 13:08:51 +0000 Original-Received: from localhost ([127.0.0.1]:51026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAVfe-0002Qy-S7 for submit@debbugs.gnu.org; Sat, 17 Jun 2023 09:08:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAVfc-0002Qk-AQ for 63967@debbugs.gnu.org; Sat, 17 Jun 2023 09:08:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAVfU-000080-Ip; Sat, 17 Jun 2023 09:08:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=67WIPnu7SHdptOrIm4omZDmDqs//tDlYOieIgEV7RJU=; b=UQJXb2x6lDF8 ZcxMR4grQJ6Hkv+PyfpNkAUSwcbnYbW4Wix8lb0SAn1dAnDDodB72KWE689FBew4Xky//Ry2TDepI LqAAhHsBgaD0Zkgi8L1aBJgMGvYDYqO9jbsKyHRuQiPZXTYv4ObsQ0Uf4U4flxC4uSffTHHE85miO GKfpaPzRVbB9aBrH1brqKzHZbHPANZfeJId5C6HMbNHuChsSmwse65u6316zTMnvCPPLkUwo/vLS6 Fjygp4CatKb32nUQeHfXRS/EszYkUpn10uPMaY5M+7sNvsBokNs/1XAx6nUj4oCPt05cxgMpIn158 okQ74pYUQoJk10RVbN+clQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAVfT-00030A-F8; Sat, 17 Jun 2023 09:08:40 -0400 In-Reply-To: (message from Alan Mackenzie on Sat, 17 Jun 2023 11:31:54 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263535 Archived-At: > Date: Sat, 17 Jun 2023 11:31:54 +0000 > Cc: al@petrofsky.org, rudalics@gmx.at, monnier@iro.umontreal.ca, > 63967@debbugs.gnu.org, acm@muc.de > From: Alan Mackenzie > > > So I hope you will present a suggested patch soon, and that it will be > > simple and safe enough to install on the release branch. TIA. > > After spending quite some time looking at why that call to > Fset_frame_selected_window went in in the first place, and checking > quite a few of the bug scenarios from 2021, I'm now convinced that the > sole fix we need is to remove that call from minibuffer_unwind. > > It's certainly a simple patch, and I think it's safe enough for Emacs > 29. Maybe other people (e.g. Martin) would be good enough to give it a > quick going over before we commit it. Thanks. Martin, please comment. Your own proposal was similar, so I hope you will agree to this.