From: Eli Zaretskii <eliz@gnu.org>
To: john muhl <jm@pub.pink>
Cc: 64344-done@debbugs.gnu.org
Subject: bug#64344: [PATCH] Make calculator work with customized mode-line
Date: Thu, 29 Jun 2023 21:22:45 +0300 [thread overview]
Message-ID: <838rc2t9fu.fsf@gnu.org> (raw)
In-Reply-To: <87jzvmp9m8.fsf@pub.pink> (message from john muhl on Thu, 29 Jun 2023 10:12:06 -0500)
> From: john muhl <jm@pub.pink>
> Cc: 64344@debbugs.gnu.org
> Date: Thu, 29 Jun 2023 10:12:06 -0500
>
> > Shouldn't that be 'consp' instead? 'listp' returns non-nil for nil
> > argument.
>
> I’m not expert enough to say more than that either way works to fix the
> issue. Originally I did the ‘(cdr lh)’ unconditionally and got an error
> mentioning ‘listp’ so I just used that when I added the condition; if it
> had said ‘conps’ I would have used that.
>
> Here is the patch with ‘consp’ instead.
Thanks. That still uses 'listp', so I fixed that manually.
This is now installed on the emacs-29 branch; closing the bug.
prev parent reply other threads:[~2023-06-29 18:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 18:23 bug#64344: [PATCH] Make calculator work with customized mode-line john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-29 7:49 ` Eli Zaretskii
2023-06-29 8:22 ` Andreas Schwab
2023-06-29 9:28 ` Eli Zaretskii
2023-06-29 9:31 ` Andreas Schwab
2023-06-29 9:38 ` Eli Zaretskii
2023-06-29 9:43 ` Andreas Schwab
2023-06-29 8:46 ` Stephen Berman
2023-06-29 9:26 ` Eli Zaretskii
2023-06-29 10:17 ` Stephen Berman
2023-06-29 15:12 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-29 18:22 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838rc2t9fu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64344-done@debbugs.gnu.org \
--cc=jm@pub.pink \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).