From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers Date: Mon, 03 Jul 2023 20:17:31 +0300 Message-ID: <838rbwncd0.fsf@gnu.org> References: <87pm5h4iy1.fsf@t510.orion.oneofus.la> <83h6qtw3tq.fsf@gnu.org> <87wmzp2e0d.fsf@t510.orion.oneofus.la> <831qhwx5qf.fsf@gnu.org> <87zg4k76es.fsf@orphne.orion.oneofus.la> <83mt0jvmfu.fsf@gnu.org> <87r0pva66g.fsf@t510.orion.oneofus.la> <834jmrv3p6.fsf@gnu.org> <87o7kz9wej.fsf@t510.orion.oneofus.la> <83wmzmuaq7.fsf@gnu.org> <87wmzmb5fl.fsf@t510.orion.oneofus.la> <83a5wita0p.fsf@gnu.org> <87ttuqax6d.fsf@t510.orion.oneofus.la> <835y75tsn7.fsf@gnu.org> <87r0ps7v92.fsf@t510.orion.oneofus.la> <831qhqq0kf.fsf@gnu.org> <87zg4dsz9y.fsf@t510.orion.oneofus.la> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27701"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64311@debbugs.gnu.org To: Vladimir Sedach , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 03 19:18:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGNBt-00071t-7j for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Jul 2023 19:18:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGNBc-0001Di-27; Mon, 03 Jul 2023 13:18:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGNBa-0001Bi-8N for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 13:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGNBZ-0001Eu-Mm for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 13:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qGNBZ-0007ls-Im for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 13:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jul 2023 17:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64311 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64311-submit@debbugs.gnu.org id=B64311.168840462429805 (code B ref 64311); Mon, 03 Jul 2023 17:18:01 +0000 Original-Received: (at 64311) by debbugs.gnu.org; 3 Jul 2023 17:17:04 +0000 Original-Received: from localhost ([127.0.0.1]:34403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGNAd-0007kf-VU for submit@debbugs.gnu.org; Mon, 03 Jul 2023 13:17:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGNAb-0007k7-Hp for 64311@debbugs.gnu.org; Mon, 03 Jul 2023 13:17:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGNAV-00015c-OC; Mon, 03 Jul 2023 13:16:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=u/2Zpt1RA7tRPp8oKCv9jOYuhJmZRuoocf29pgGtbyU=; b=L3XwTnYkPXXE yOEf/LK2VmRqZWmqxleW9nK+sVy3ZuLtYR3a50n5WabBASY2qGd/bk292FF5VLpaa6khlNgRZ7VmG NpguXvtPmp61uqgM/T1W6iQPMgF6zDIg1Tu3jQhT0s66e4OcqeYTQpCEX0YYiIHg0Lv03XDaAjQ7H 7smcP+GEG1Og8Yki8teG8wmeRTT90Hgc6P0C1Uos5V7coVeo+Kh+LyjqUsJgBMnYq6WN9STZvncW0 2HMCGtzzhm1hdic5EZz9kwEfVCysnaGhzTF0ZNrP3NHcKs3DtFMTN9lD3SUS4ixrXGnH8tw0adXS7 pWCmE+WDF+rySdS1Qxt6Mg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGNAV-0005uV-8t; Mon, 03 Jul 2023 13:16:55 -0400 In-Reply-To: <87zg4dsz9y.fsf@t510.orion.oneofus.la> (message from Vladimir Sedach on Mon, 03 Jul 2023 11:03:37 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264539 Archived-At: > From: Vladimir Sedach > Cc: 64311@debbugs.gnu.org > Date: Mon, 03 Jul 2023 11:03:37 -0600 > > > Eli Zaretskii writes: > > I think the alternative patch below solves all those issues. If you > > disagree, pleased tell what left-over problems you see after applying > > that patch. > > How should defvaralias be used? > > On the master branch I count 74 defvaralias declarations in lisp/, > excluding lisp/obsolete/ (there are some more generated dynamically > by org-babel). Of these, 73 are used for variable rename refactoring > (the 1 other use is vhdl-last-input-event as a compatibility shim for > xemacs). > > There were 2 things that to me looked wrong with the existing > defvaralias declaration in shell.el: > > 1. As far as I can tell, every declaration aside from shell.el is of > the form (defvaralias old-variable new-variable). The one in > shell.el is the other way around. > > 2. There are only 2 occurrences where the old variable is still > referenced in Emacs code: erc-join-buffer and shell-dirtrackp > > Isn't the point of defvaralias in removing uses of the old variable > name from Emacs code? I'm not sure. You may be right. Let's see if Stefan (CC'ed) has any comments. But in any case, given how long we have this arrangement, I wouldn't make any changes in it unless it causes real problems. And I think after installing the simple changes I proposed there are no real problems left to justify such changes.