From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Mon, 17 Jul 2023 14:20:04 +0300 Message-ID: <838rbe944b.fsf@gnu.org> References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <87ttu4gnpt.fsf@localhost> <83351o9m6h.fsf@gnu.org> <87ilakgmjo.fsf@localhost> <83pm4r9apt.fsf@gnu.org> <83mszv93yb.fsf@gnu.org> <83edl78yly.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4148"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, 64596@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 17 13:55:43 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qLMpL-0000ve-1k for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jul 2023 13:55:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLMGu-0000zw-6V; Mon, 17 Jul 2023 07:20:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLMGp-0000yj-4x for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 07:20:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLMGo-0003Yf-RE for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 07:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLMGo-00056u-6L for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 07:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jul 2023 11:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168959278819617 (code B ref 64596); Mon, 17 Jul 2023 11:20:02 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 17 Jul 2023 11:19:48 +0000 Original-Received: from localhost ([127.0.0.1]:49138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLMGZ-00056K-MX for submit@debbugs.gnu.org; Mon, 17 Jul 2023 07:19:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLMGX-000564-63 for 64596@debbugs.gnu.org; Mon, 17 Jul 2023 07:19:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLMGQ-0003OS-QO; Mon, 17 Jul 2023 07:19:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NCBsiLfVDzxZZsYm25kKVof6D4AUH33s4tgjBswGl4Q=; b=Zq0Q80HCbbjN uZNE5A6jTUTRiZTRd2muZ0KHDftMndTy9RxbOLH9OV/7NmqCJE7H08fmepe819UevRPhE1LqpX0Wh vVK3iyF29uUR5AzbrggKej3Jo6aftfjkiz2Tck88Y0JYPWPCJFjbWFoyrgYi8gqDOWhiEaNsQ72lc Vv9DsXC36A86QiS5NQaUK3XFyCimiAGydNztv61xKmJZ0BA7matwWzfnoltKMEJeQ+PD99JRfpaWo ImOPqwyWGIyjfdGXjBWISKY7EmlhsRGoSDf1Kk9x3pOCvWvfWOl7P5gyY0QTFoipNq5QIKEUUwBSK 0MW3hyB+Oxr34yR5EPiGfQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLMGQ-00052q-AD; Mon, 17 Jul 2023 07:19:38 -0400 In-Reply-To: (message from Stefan Monnier on Sun, 16 Jul 2023 18:19:57 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265383 Archived-At: > From: Stefan Monnier > Cc: yantar92@posteo.net, 64596@debbugs.gnu.org > Date: Sun, 16 Jul 2023 18:19:57 -0400 > > > That's not all of the uses of this flag. Here's one example of other > > uses: > > > > if (some_windows > > && !f->redisplay > > && !w->redisplay > > && !XBUFFER (w->contents)->text->redisplay) > > continue; > > > > (This avoids updating the tool bar and the tab bar of the frame, and > > there's a similar condition that avoids updating the frame's title.) > > Right, but notice that what we're fundamentally checking is whether `w` > (which is the frame's selected window here) needs to be updated, because > that's the one currently "occupying" the tool-bar. But testing the frame's redisplay flag will produce false positives, because many changes that require to redraw the frame's windows don't affect the tool bar or the frame's title. > FWIW, I don't know why we don't also check > `XBUFFER(w->contents)->redisplay` here. We do: if (some_windows && !f->redisplay && !w->redisplay && !XBUFFER (w->contents)->text->redisplay) <<<<<<<<<<< continue; > Also, I still don't see why that makes you think: > > frame's redisplay flag is what causes us to consider a frame in the > first place. > > Indeed, a frame's redisplay flag may be such a reason, but a window's > flag or its text buffer's may be the reason instead. A frame's > `redisplay` flag does not need to be set for us to consider it. No, my point is that fset_redisplay shouldn't set windows_or_buffers_changed.