From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67563: 30.0.50; Box should not extend with line-spacing Date: Sat, 02 Dec 2023 16:06:54 +0200 Message-ID: <838r6c8zr5.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31525"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67563@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 02 15:08:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r9QfI-0007wk-7U for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Dec 2023 15:08:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r9Qez-0004FQ-F3; Sat, 02 Dec 2023 09:07:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9Qev-0004FG-Kq for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2023 09:07:53 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r9Qeu-0007zh-T1 for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2023 09:07:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r9Qf4-0008JV-4b for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2023 09:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Dec 2023 14:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67563 X-GNU-PR-Package: emacs Original-Received: via spool by 67563-submit@debbugs.gnu.org id=B67563.170152603631906 (code B ref 67563); Sat, 02 Dec 2023 14:08:02 +0000 Original-Received: (at 67563) by debbugs.gnu.org; 2 Dec 2023 14:07:16 +0000 Original-Received: from localhost ([127.0.0.1]:56951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9QeJ-0008IY-Hu for submit@debbugs.gnu.org; Sat, 02 Dec 2023 09:07:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9QeH-0008IL-NR for 67563@debbugs.gnu.org; Sat, 02 Dec 2023 09:07:14 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9Qe2-0007t0-Vu; Sat, 02 Dec 2023 09:06:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5BxWjklFnwfmxqgb147EvrhuiH0t2YqezB35CATH27M=; b=lsW9ha/NXgoF tfbM8CjUsZIY3v6PgxeJ5pGkCYABpF8QwpBUNE1CC+3Vz3ZMkEqgXWo7sMxl3R7DewbxK7Eh2gqX2 TV/Gkbbk/Dx8T+5F7AUCJppwev8znqmqm3HZYJ5G5RU2+FKjdinoK6aUdLFWxiI4wdS8vQtmugx5i +POfk77rFkcBEFWrbHy9fyU03MExrDX7WXiySw3m9hays5YQu8W3TOdf5QxiLi8NriqItK48YJ1y5 sgQhDYgz+N7auqr8IgGgYIv75gOpI3YSZ3++12yLIOHGAQY3EPaf2oPiUduR6488OckRocCqa+pri fRTUxDJOQlUE58kr5z8VeQ==; In-Reply-To: (message from Yuan Fu on Thu, 30 Nov 2023 23:47:37 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275382 Archived-At: > From: Yuan Fu > Date: Thu, 30 Nov 2023 23:47:37 -0800 > > If I set a box face for a button, and then set a line-space for the buffer, I expect the extra space between lines to be added outside of the box, like so: > > +-------------------------+ > | Box | > | | > +-------------------------+ > extra line space > +-------------------------+ > | Box | > | | > +-------------------------+ > > However, right now, the bottom line of the box includes the extra line spacing, like so: > > +-------------------------+ > | Box | > | | > + + > | extra line space | > +-------------------------+ > +-------------------------+ > | Box | > | | > +-------------------------+ > > Screenshot: > > Ideally there should be some space between the two buttons on the two lines. Also notice the extra space above the bottom line of the box. > > I also attached a repo file to produce these buttons. > > If someone can give me some pointers, I can try to look into this. We currently draw the box such that its height is equal to the height of the screen line, and that includes line-spacing. The implementation is in x_draw_glyph_string_box and similar functions in other GUI backends (w32_draw_glyph_string_box etc.). If you want to ad a feature where the box excludes line-space, please make it optional, by default off, as the current behavior is a very old one.