From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70038: 29.3.50; Shift up/down in buffer with images on M-x other-window with some fonts Date: Wed, 17 Apr 2024 10:02:12 +0200 Message-ID: <838b8ff4-36f2-476f-acef-6f331867bb1d@gmx.at> References: <87ttkrl8w1.fsf@gmail.com> <86zfuihp7t.fsf@gnu.org> <87bk6yl4hu.fsf@gmail.com> <8734sal2bc.fsf@gmail.com> <87wmpm2rd7.fsf@zohomail.eu> <86bk6m3c20.fsf@gnu.org> <867cha37of.fsf@gnu.org> <3ee13fbd-2ba0-4fca-b5ed-b61f1d8dc527@gmx.at> <864jcd1qok.fsf@gnu.org> <8634rx1kfb.fsf@gnu.org> <028e677b-6d6b-42b2-95ac-0e0c5d1f3dd1@gmx.at> <86jzl1po87.fsf@gnu.org> <865xwknvhs.fsf@gnu.org> <86bk6aloj7.fsf@gnu.org> Reply-To: martin rudalics Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25177"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: luangruo@yahoo.com, 70038@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 17 10:03:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rx0GC-0006Gx-Jv for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Apr 2024 10:03:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rx0Fs-0000Jo-JF; Wed, 17 Apr 2024 04:02:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rx0Fl-0000IP-8x for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2024 04:02:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rx0Fl-0003ta-0q for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2024 04:02:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rx0Fx-0003AX-OD for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2024 04:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Apr 2024 08:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70038 X-GNU-PR-Package: emacs Original-Received: via spool by 70038-submit@debbugs.gnu.org id=B70038.171334096612023 (code B ref 70038); Wed, 17 Apr 2024 08:03:01 +0000 Original-Received: (at 70038) by debbugs.gnu.org; 17 Apr 2024 08:02:46 +0000 Original-Received: from localhost ([127.0.0.1]:45648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx0Fd-00037J-Nt for submit@debbugs.gnu.org; Wed, 17 Apr 2024 04:02:45 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:52399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx0FW-000356-Lg for 70038@debbugs.gnu.org; Wed, 17 Apr 2024 04:02:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1713340934; x=1713945734; i=rudalics@gmx.at; bh=Ppyn5or2JVfb0QvYTb9ZXaF0r/PAF/SGrOJlNcymvco=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=GGuaQQWXg45vp/n4Z8ali/+q+vlawM/Ft1VpuiA4b5/7WVMF8a13d2uWxg6sodMN 69DKc1sn8Kbp/rO9e15wkl8A+vutyN/ew8m7aJE7RDcJq8o7pTA060U1SGLa5dsmP kbvq2FUm3/k/dxZQuVXeh2dy8Y71KUPzwbHnnsMb/cyPSAF4BhzEg9FkjJ8ze+lt9 Z9ph5BvFXo4u7tOW7xbEVh4RVdE/dWDMJxzPfBptoOcN9PhzDDZlDTUO8iloHnyBr wHVTsYGyYDDOo8UiM1C6qLRtN6xzUQMwJOD5ZhSY5tyJmj69WUT86aTV8BLfxZqDb AKR/jZdCGlfAu/WKLQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.31.113] ([212.95.8.141]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MdNY8-1sW40r3YXI-00ZQNc; Wed, 17 Apr 2024 10:02:13 +0200 Content-Language: en-US In-Reply-To: <86bk6aloj7.fsf@gnu.org> X-Provags-ID: V03:K1:7t4XP2VJkAszNB29PiUkqILWuKJTEFF03Yp2tLP6tXmatst9nj8 aId5OwsqSyXH/zBupKxqn4FKk12HmbmLSdNXKhtbtvWM+qWk+uA6jAqRny/J6U3t91lTC/x 1Ga2WvOCJKHMvWc2I7tleGvAFlKXLZejfxTfx6ThEM2wGQ03jCS14fJ3khjx4annV9SnqQ/ VvDLt/1CN0ppabVwZbocQ== UI-OutboundReport: notjunk:1;M01:P0:PKxL9zblYgc=;LYpYLgdWqPPS0HW77EtDwymYY1d r78PaqFm3YI/4hSBseX9yZnFQq5FtAd8mP6zvlmBsmwLCJj7WL01B0JHDXny5+YzvQ2xbd4v9 jYIC3f0ad0D+jGhYK2drVst1BTV8wnJmEdIMmCTBRHFfsJC6g3Y4xcCTp2nDFOsroWYrDmxG8 MgPjCZ3FeJfDRZ7pFAh0Ub5Gbimwho0FH+TAw0rsN5RZj6+vbWRvIZyFnMqyN/tbyoVxxGkkO B9L6b1d8vAYRJVHnGsYIWyCeGpu8o+3hhLlkqCPizkZ/Z9dEKpRe+7yFcOmjLokp5cpy2exx4 rUNPvC6lxnYFJqb0FLRc+vU5CUFxyqcgx4XehGFwzDYzu94E0WKo0bbtnZCApproQiaF8fXLE Ge8YVOrGV3sbaBpnZmXpCmQP4wNzXMxWtXaedOKKTrGtPiaYzHUd/jeMQgXfWXWS9kKfz32On laMehCLTrKBJ9BaYhfSijHo6/weRc47W8rOBlNQgsJ1ukaMbo3Or6s2l+cABFyUvdW8UO8KyQ D4aWGm3v3uOq7tWCzX5+m44qhPOENKw2SXMNYD2vIfCC3ftF3AtpX8Ld4oLGsOY4DC+GfTXSJ FZuK4Xq+ImpPPcfVByxZfJ5PhPAQthL49lDa4URhol2z90JC2maf/GoCHIHjNRBLzUh6rI17G DFcJeV7LnhzvxNYQoyl7lpKZdvjOoc/hhDoQBgZmis+aSmsH5LnwtpRYZzm4CUEIWwB5IVMeY pNMSEJeifJ7hbkTSxqQCEVhplR0rNrkKsBqzfrGmLbXv4UghaV3vNxQB51Kw244pKZkGvTTt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283475 Archived-At: > I hope this is now more clear. Thanks. So when we enter the part headed by if ((w->optional_new_start || window_frozen_p (w)) then the single aim is apparently to make sure that the cursor line remains fully visible. When we enter that part because window_frozen_p (w) is set, we ignore the scroll margins because we assume that preserving the window start position is more important in this situation. When we enter that part because w->optional_new_start was set, we assume that the caller ('recenter', 'delete-other-windows-internal') has done its part to obey the scroll margins but still might have failed to keep the cursor visible. Is that interpretation correct? If so, it might make sense to put some explanation into a comment for that part because, at least for me, it's a priori not clear that the same treatment is wanted for keeping the previous start position of a window and for one that has been explicitly changed. I've spent almost an hour to arrive at the conclusion above. Things like this comment in 'delete-other-windows-internal' /* We need to do this, so that the window-scroll-functions get called. */ w->optional_new_start = true; were distracting even further. martin