From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#24594: 24.5; `variable-pitch-mode': accept FACE arg instead of hardcoding the face Date: Tue, 4 Oct 2016 20:28:11 -0700 (PDT) Message-ID: <83862660-197c-4647-91a0-b8330bab231f@default> References: <587cb6c7-44f8-4546-91ee-264416c965d6@default> <87eg3vy7jn.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1475638176 8403 195.159.176.226 (5 Oct 2016 03:29:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Oct 2016 03:29:36 +0000 (UTC) Cc: 24594@debbugs.gnu.org, =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 05 05:29:31 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brctR-0008J7-BL for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Oct 2016 05:29:17 +0200 Original-Received: from localhost ([::1]:46274 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brctP-0001J3-Tn for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Oct 2016 23:29:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brctH-0001H4-5B for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 23:29:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brctC-0004NJ-NP for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 23:29:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brctC-0004ND-Jo for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 23:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1brctC-0007Pm-FW for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 23:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Oct 2016 03:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24594 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24594-submit@debbugs.gnu.org id=B24594.147563810328452 (code B ref 24594); Wed, 05 Oct 2016 03:29:02 +0000 Original-Received: (at 24594) by debbugs.gnu.org; 5 Oct 2016 03:28:23 +0000 Original-Received: from localhost ([127.0.0.1]:45081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brcsZ-0007Oo-7h for submit@debbugs.gnu.org; Tue, 04 Oct 2016 23:28:23 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:25935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brcsX-0007Oc-L0 for 24594@debbugs.gnu.org; Tue, 04 Oct 2016 23:28:22 -0400 Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u953SFO6014984 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 Oct 2016 03:28:15 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id u953SEQu017850 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 Oct 2016 03:28:15 GMT Original-Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u953SE2x013031; Wed, 5 Oct 2016 03:28:14 GMT In-Reply-To: <87eg3vy7jn.fsf@users.sourceforge.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124082 Archived-At: > Doesn't this already exist as buffer-face-set? Not really. Nor is it `buffer-face-mode'. The closest is `buffer-face-toggle'. FWIW, I'm OK with eliminating `variable-pitch-mode' altogether. I don't really see the point of a version of `buffer-face-mode' that is limited to one face. Likewise, eliminating face `variable-pitch' - fine by me. As I said earlier, faces should not be named after some default value of an attribute (e.g. `red-foreground' face or `variable-pitch' face). But if there is some good reason why we should have a `variable-pitch-mode' and a face that REALLY is limited to variable-pitch fonts, then the defface should actually limit the attribute values so that the face is always a variable-pitch face. IF we should have a `variable-pitch-mode' then I think it should accept a face argument. One way to make it possible to specify the face interactively would be to have a specific kind of non-nil prefix arg prompt you for a face name (`read-face-name'). For more-or-less backward compatibility (not that anyone has used the command, perhaps) would be to have a negative prefix arg prompt for the face name (as well as turning on the mode). As you can tell, I don't care much about this one way or another. I don't use it and likely never will. I don't really see the point of it, as currently defined. Whether it could prove to be useful if improved a bit, I don't know.