unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: npostavs@users.sourceforge.net
Cc: 24594@debbugs.gnu.org, "Clément Pit--Claudel" <clement.pit@gmail.com>
Subject: bug#24594: 24.5; `variable-pitch-mode': accept FACE arg instead of hardcoding the face
Date: Tue, 4 Oct 2016 20:28:11 -0700 (PDT)	[thread overview]
Message-ID: <83862660-197c-4647-91a0-b8330bab231f@default> (raw)
In-Reply-To: <87eg3vy7jn.fsf@users.sourceforge.net>

> Doesn't this already exist as buffer-face-set?

Not really.  Nor is it `buffer-face-mode'.
The closest is `buffer-face-toggle'.

FWIW, I'm OK with eliminating `variable-pitch-mode'
altogether.  I don't really see the point of a version
of `buffer-face-mode' that is limited to one face.

Likewise, eliminating face `variable-pitch' - fine by
me.  As I said earlier, faces should not be named after
some default value of an attribute (e.g. `red-foreground'
face or `variable-pitch' face).

But if there is some good reason why we should have a
`variable-pitch-mode' and a face that REALLY is limited
to variable-pitch fonts, then the defface should actually
limit the attribute values so that the face is always a
variable-pitch face.

IF we should have a `variable-pitch-mode' then I think
it should accept a face argument.

One way to make it possible to specify the face
interactively would be to have a specific kind of non-nil
prefix arg prompt you for a face name (`read-face-name').

For more-or-less backward compatibility (not that
anyone has used the command, perhaps) would be to have
a negative prefix arg prompt for the face name (as well
as turning on the mode).

As you can tell, I don't care much about this one way or
another.  I don't use it and likely never will.  I don't
really see the point of it, as currently defined.
Whether it could prove to be useful if improved a bit,
I don't know.





  reply	other threads:[~2016-10-05  3:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-03  3:22 bug#24594: 24.5; `variable-pitch-mode': accept FACE arg instead of hardcoding the face Drew Adams
2016-10-03  3:39 ` Clément Pit--Claudel
2016-10-03  3:48   ` Drew Adams
2016-10-03  7:00     ` Eli Zaretskii
2016-10-05  0:16     ` npostavs
2016-10-05  3:28       ` Drew Adams [this message]
2016-10-05 12:29         ` npostavs
2016-10-05 15:14           ` Drew Adams
2016-10-05 15:32             ` Noam Postavsky
2016-10-05 15:51               ` Drew Adams
2016-10-05 21:43                 ` Noam Postavsky
2016-10-06 16:24                   ` Drew Adams
     [not found]   ` <<587cb6c7-44f8-4546-91ee-264416c965d6@default>
     [not found]     ` <<83oa31q5mr.fsf@gnu.org>
2016-10-03 13:36       ` Drew Adams
2016-10-03 14:12         ` Eli Zaretskii
2016-12-07 20:15           ` Glenn Morris
     [not found]   ` <<<587cb6c7-44f8-4546-91ee-264416c965d6@default>
     [not found]     ` <<<83oa31q5mr.fsf@gnu.org>
     [not found]       ` <<3a104ad1-ccf9-4b54-9773-e939d74aaac1@default>
     [not found]         ` <<83d1jhplmf.fsf@gnu.org>
2016-10-03 14:51           ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83862660-197c-4647-91a0-b8330bab231f@default \
    --to=drew.adams@oracle.com \
    --cc=24594@debbugs.gnu.org \
    --cc=clement.pit@gmail.com \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).