unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: dcl441-bugs@yahoo.com
Cc: 9738@debbugs.gnu.org
Subject: bug#9738: 24.0.90; Crash at overlay-put-ov 'after-string
Date: Wed, 12 Oct 2011 19:59:54 +0200	[thread overview]
Message-ID: <837h4a3xb9.fsf@gnu.org> (raw)
In-Reply-To: <1318437830.56119.YahooMailClassic@web161203.mail.bf1.yahoo.com>

> Date: Wed, 12 Oct 2011 09:43:50 -0700 (PDT)
> From: Daniel Clemente <dcl441-bugs@yahoo.com>
> 
> 1. emacs -Q
> 2. Eval the following:
>   (setq ov (make-overlay 1 2))
>   (overlay-put ov 'after-string "\n111\n2" )
> 3. Crash. This stacktrace appears under gdb:

Please see if the patch below fixes the problem.  I cannot reproduce
the crash with your recipe, so I cannot verify that it's fixed by this
patch.

Thanks.

=== modified file 'src/bidi.c'
--- src/bidi.c	2011-10-12 15:12:52 +0000
+++ src/bidi.c	2011-10-12 17:56:48 +0000
@@ -808,7 +808,6 @@ bidi_init_it (EMACS_INT charpos, EMACS_I
   bidi_it->nchars = -1;	/* to be computed in bidi_resolve_explicit_1 */
   bidi_it->first_elt = 1;
   bidi_set_paragraph_end (bidi_it);
-  bidi_it->paragraph_dir = NEUTRAL_DIR;
   bidi_it->new_paragraph = 1;
   bidi_it->separator_limit = -1;
   bidi_it->type = NEUTRAL_B;

=== modified file 'src/xdisp.c'
--- src/xdisp.c	2011-10-12 15:12:52 +0000
+++ src/xdisp.c	2011-10-12 17:56:28 +0000
@@ -19479,6 +19479,7 @@ See also `bidi-paragraph-direction'.  */
 	    bytepos--;
 	}
       bidi_init_it (pos, bytepos, FRAME_WINDOW_P (SELECTED_FRAME ()), &itb);
+      itb.paragraph_dir = NEUTRAL_DIR;
       itb.string.s = NULL;
       itb.string.lstring = Qnil;
       itb.string.bufpos = 0;






  reply	other threads:[~2011-10-12 17:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12 16:43 bug#9738: 24.0.90; Crash at overlay-put-ov 'after-string Daniel Clemente
2011-10-12 17:59 ` Eli Zaretskii [this message]
2011-10-12 20:20   ` Eli Zaretskii
2011-10-12 20:46     ` Daniel Clemente
2011-10-12 21:49       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837h4a3xb9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=9738@debbugs.gnu.org \
    --cc=dcl441-bugs@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).