From: Eli Zaretskii <eliz@gnu.org>
To: eggert@cs.ucla.edu, stephen_powell@optusnet.com.au
Cc: 12829-done@debbugs.gnu.org
Subject: bug#12829: 24.3.50; emacs_abort () called from w32proc.c:1128
Date: Sat, 17 Nov 2012 18:50:43 +0200 [thread overview]
Message-ID: <837gpk2mxo.fsf@gnu.org> (raw)
In-Reply-To: <838va02q64.fsf@gnu.org>
> Date: Sat, 17 Nov 2012 17:40:51 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: stephen_powell@optusnet.com.au, 12829@debbugs.gnu.org
>
> > Date: Sat, 17 Nov 2012 07:35:54 -0800
> > From: Paul Eggert <eggert@cs.ucla.edu>
> > CC: Stephen Powell <stephen_powell@optusnet.com.au>,
> > 12829@debbugs.gnu.org
> >
> > On 11/16/2012 11:09 PM, Eli Zaretskii wrote:
> > > Any news? Should I commit the changes?
> >
> > I don't see anything about it that would break things,
> > though I'm looking only at the non-Windows part.
>
> Thanks, I will install in a short while.
Done as trunk revision 110922. I'm closing the bug report.
> > The following change to wait_for_termination_1
> > would be simpler, assuming the Windows waitpid emulation
> > is good enough now.
> >
> > === modified file 'src/sysdep.c'
> > --- src/sysdep.c 2012-11-14 04:55:41 +0000
> > +++ src/sysdep.c 2012-11-17 15:33:25 +0000
> > @@ -289,10 +289,6 @@ wait_for_termination_1 (pid_t pid, int i
> > {
> > while (1)
> > {
> > -#ifdef WINDOWSNT
> > - wait (0);
> > - break;
> > -#else /* not WINDOWSNT */
> > int status;
> > int wait_result = waitpid (pid, &status, 0);
> > if (wait_result < 0)
> > @@ -306,7 +302,6 @@ wait_for_termination_1 (pid_t pid, int i
> > break;
> > }
> >
> > -#endif /* not WINDOWSNT */
> > if (interruptible)
> > QUIT;
> > }
>
> Yes, I plan to do that
Done as well. I also removed the remaining fragments that catered to
systems without WNOHANG, as there are no such system anymore.
next prev parent reply other threads:[~2012-11-17 16:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 23:47 bug#12829: 24.3.50; emacs_abort () called from w32proc.c:1128 Stephen Powell
2012-11-08 3:46 ` Eli Zaretskii
2012-11-08 15:48 ` Stephen Powell
2012-11-09 9:41 ` Eli Zaretskii
2012-11-09 18:59 ` Stephen Powell
2012-11-09 19:38 ` Eli Zaretskii
2012-11-09 20:16 ` Stephen Powell
2012-11-10 8:27 ` Eli Zaretskii
2012-11-10 14:56 ` Eli Zaretskii
2012-11-10 21:44 ` Paul Eggert
2012-11-11 3:50 ` Eli Zaretskii
2012-11-10 15:45 ` Stephen Powell
2012-11-10 16:09 ` Eli Zaretskii
2012-11-10 18:03 ` Stephen Powell
2012-11-10 18:34 ` Eli Zaretskii
2012-11-17 7:09 ` Eli Zaretskii
2012-11-17 15:35 ` Paul Eggert
2012-11-17 15:40 ` Eli Zaretskii
2012-11-17 16:50 ` Eli Zaretskii [this message]
2012-11-17 15:32 ` Stephen Powell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837gpk2mxo.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=12829-done@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=stephen_powell@optusnet.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).