bug#14100: 24.3.50; emacs_backtrace.txt

bug#14100: 24.3.50; emacs_backtrace.txt

[Drew Adams]

Backtrace:
0x01159769
0x011597DB
0x012E3AB5
0x010CCD49
0x01039DCD
0x0103BA2C
0x01024070
0x01010C39
0x01023814
0x01010696
0x010237CE
0x01022D88
0x010230B5
0x010029C4
0x010010F9
0x7C81776B

In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2013-03-28 on ODIEONE
Bzr revision: 112173 monnier@iro.umontreal.ca-20130328163306-419khox8aneaoaxv
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'
 

bug#14100: 24.3.50; emacs_backtrace.txt

[Eli Zaretskii]

> From: "Drew Adams" <drew.adams@oracle.com>
> Date: Sat, 30 Mar 2013 15:51:52 -0700
> 
> Backtrace:
> 0x01159769
> 0x011597DB
> 0x012E3AB5
> 0x010CCD49
> 0x01039DCD
> 0x0103BA2C
> 0x01024070
> 0x01010C39
> 0x01023814
> 0x01010696
> 0x010237CE
> 0x01022D88
> 0x010230B5
> 0x010029C4
> 0x010010F9
> 0x7C81776B

  w32_backtrace at C:\Devel\emacs\repo\build\src/w32fns.c:7729
  emacs_abort at C:\Devel\emacs\repo\build\src/w32fns.c:7761
  get_local_map at C:\Devel\emacs\repo\build\src/intervals.c:2212
  Fcurrent_active_maps at C:\Devel\emacs\repo\build\src/keymap.c:1611
  active_maps at C:\Devel\emacs\repo\build\src/keyboard.c:8572
  read_key_sequence at C:\Devel\emacs\repo\build\src/keyboard.c:9201
  command_loop_1 at C:\Devel\emacs\repo\build\src/keyboard.c:1458
  internal_condition_case at C:\Devel\emacs\repo\build\src/eval.c:1193
  command_loop_2 at C:\Devel\emacs\repo\build\src/keyboard.c:1173
  internal_catch at C:\Devel\emacs\repo\build\src/eval.c:964
  command_loop at C:\Devel\emacs\repo\build\src/keyboard.c:1152
  recursive_edit_1 at C:\Devel\emacs\repo\build\src/keyboard.c:785
  Frecursive_edit at C:\Devel\emacs\repo\build\src/keyboard.c:849
  main at C:\Devel\emacs\repo\build\src/emacs.c:1531
  ?? at crt1.c:0

The abort is here (in get_local_map):

  /* Perhaps we should just change `position' to the limit.  */
  if (position > BUF_ZV (buffer) || position < BUF_BEGV (buffer))
    emacs_abort ();

The caller, Fcurrent_active_maps, checks a different condition before
the call:

	      pos = POSN_BUFFER_POSN (position);
	      if (INTEGERP (pos)
		  && XINT (pos) >= BEG && XINT (pos) <= Z)
		{
		  local_map = get_local_map (XINT (pos),
					     current_buffer, Qlocal_map);


So perhaps the bug is in the caller: it should test BEGV and ZV
instead of BEG and Z.

bug#14100: 24.3.50; emacs_backtrace.txt

[Lars Ingebrigtsen]

> The abort is here (in get_local_map):
>
>   /* Perhaps we should just change `position' to the limit.  */
>   if (position > BUF_ZV (buffer) || position < BUF_BEGV (buffer))
>     emacs_abort ();
>
> The caller, Fcurrent_active_maps, checks a different condition before
> the call:
>
> 	      pos = POSN_BUFFER_POSN (position);
> 	      if (INTEGERP (pos)
> 		  && XINT (pos) >= BEG && XINT (pos) <= Z)
> 		{
> 		  local_map = get_local_map (XINT (pos),
> 					     current_buffer, Qlocal_map);
>
> So perhaps the bug is in the caller: it should test BEGV and ZV
> instead of BEG and Z.

Was there anything to be done here?  It sounds like it, but then there
were no further messages.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#14100: 24.3.50; emacs_backtrace.txt

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Drew Adams <drew.adams@oracle.com>,  14100@debbugs.gnu.org
> Date: Tue, 29 Dec 2015 12:09:56 +0100
> 
> > The abort is here (in get_local_map):
> >
> >   /* Perhaps we should just change `position' to the limit.  */
> >   if (position > BUF_ZV (buffer) || position < BUF_BEGV (buffer))
> >     emacs_abort ();
> >
> > The caller, Fcurrent_active_maps, checks a different condition before
> > the call:
> >
> > 	      pos = POSN_BUFFER_POSN (position);
> > 	      if (INTEGERP (pos)
> > 		  && XINT (pos) >= BEG && XINT (pos) <= Z)
> > 		{
> > 		  local_map = get_local_map (XINT (pos),
> > 					     current_buffer, Qlocal_map);
> >
> > So perhaps the bug is in the caller: it should test BEGV and ZV
> > instead of BEG and Z.
> 
> Was there anything to be done here?  It sounds like it, but then there
> were no further messages.  :-)

The call to emacs_abort is no longer in the source.  Instead, we have
this:

    position = clip_to_bounds (BUF_BEGV (buffer), position, BUF_ZV (buffer));

So I'm closing the bug, as the problem can no longer happen.