From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 15015@debbugs.gnu.org
Subject: bug#15015: Fix some minor races in hosts lacking mkostemp
Date: Sun, 04 Aug 2013 18:44:24 +0300 [thread overview]
Message-ID: <837gg1xxyf.fsf@gnu.org> (raw)
In-Reply-To: <51FD757C.401@cs.ucla.edu>
> Date: Sat, 03 Aug 2013 14:26:20 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: 15015@debbugs.gnu.org
>
> On 08/03/2013 07:55 AM, Eli Zaretskii wrote:
>
> > gettimeofday, open, and lstat are implemented by Emacs in w32.c. At
> > lest the last 2 are not equivalent to what gnulib uses.
>
> The lack of equivalence shouldn't matter. The lstat call
> (though it is compiled) won't be used by Emacs's use of the
> mkostemp module on Microsoft platforms, so it's OK.
> mkostemp always calls 'open' with O_CREAT | O_EXCL; in that
> case sys_open is just a simple wrapper around _open, so that
> should be OK too. And gettimeofday, as you mentioned, isn't
> a problem.
I think sys_open also sets the no-inherit flag, so it's not just a
wrapper.
In any case, even if you are right (and I don't have enough resources
at the moment to verify that), reusing most of the code of sys_mktemp
to implement mkostemp seems like a safer bet, since that code is
already well tested by years of usage. This also has the nice benefit
of not breaking the old configure.bat build.
So I went ahead and implemented mkostemp for MS-Windows (trunk
revision 113687). I also removed sys_mktemp, as it is no longer
needed.
> >> Presumably nt/configure.bat and makefile-w32.in could be updated
> >> to compile the new files. This sort of thing should be routine,
> >> if that avenue is still supported.
> >
> > This "support" needs volunteers, which didn't yet show up.
>
> If nobody's supporting it, then it's not really supported.
That's true, but I'd like to avoid breaking it for as long as is
feasible, to let people adapt.
> > We can always install the gnulib stuff for those other platforms
>
> Yes, that's a given. We need to do that, to fix the race
> condition bugs in OS X, Solaris, etc.
Please go ahead.
> > and work around it on Windows.
>
> I'm trying to help save work in the Windows port, by having
> Windows Emacs use Gnulib mkostemp (which will be in the
> source code anyway) the same way it's being used on OS X etc.
> If this approach is feasible, it should save us all some
> work; if not, it should be easy for a Windows expert to work
> around any problems in w32.c and/or msdos.c.
This approach is generally feasible, and I appreciate your efforts.
It's just that in this case having a Windows-specific implementation
was easy.
(Don't worry about msdos.c, I will fix that when I have time. There
can be no race conditions on MSDOS anyway...)
Thanks.
next prev parent reply other threads:[~2013-08-04 15:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-03 7:40 bug#15015: Fix some minor races in hosts lacking mkostemp Paul Eggert
2013-08-03 8:38 ` Eli Zaretskii
2013-08-03 9:02 ` Eli Zaretskii
2013-08-03 14:40 ` Paul Eggert
2013-08-03 14:55 ` Eli Zaretskii
2013-08-03 21:26 ` Paul Eggert
2013-08-04 15:44 ` Eli Zaretskii [this message]
2013-08-04 17:01 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837gg1xxyf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=15015@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).