From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#5721: Feature request: Function that returns absolute coordinates Date: Fri, 04 Oct 2013 11:55:23 +0300 Message-ID: <837gdtct50.fsf@gnu.org> References: <4B9E4521.9030909@yahoo.co.jp> <87fvsoemnj.fsf@hochschule-trier.de> <52480060.7020309@gmx.at> <87mwmvtz26.fsf@hochschule-trier.de> <6CBDC204-ABA9-41D4-BD59-4B66DF82B9D9@swipnet.se> <524875AC.5020104@gmx.at> <87ioxe8dxp.fsf@hochschule-trier.de> <83hacycdan.fsf@gnu.org> <87eh8283jm.fsf@hochschule-trier.de> <83bo35cz1x.fsf@gnu.org> <874n8xh23i.fsf@hochschule-trier.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1380876973 8745 80.91.229.3 (4 Oct 2013 08:56:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Oct 2013 08:56:13 +0000 (UTC) Cc: 5721@debbugs.gnu.org To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 04 10:56:15 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VS1BG-0001oL-PL for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Oct 2013 10:56:14 +0200 Original-Received: from localhost ([::1]:46958 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS1BG-0003LZ-GL for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Oct 2013 04:56:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS1B9-0003LS-C7 for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2013 04:56:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VS1B4-0005L4-Ii for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2013 04:56:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS1B4-0005L0-Fe for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2013 04:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VS1B4-0008Rn-1t for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2013 04:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Oct 2013 08:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5721 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5721-submit@debbugs.gnu.org id=B5721.138087694532445 (code B ref 5721); Fri, 04 Oct 2013 08:56:01 +0000 Original-Received: (at 5721) by debbugs.gnu.org; 4 Oct 2013 08:55:45 +0000 Original-Received: from localhost ([127.0.0.1]:53172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VS1Am-0008RD-2S for submit@debbugs.gnu.org; Fri, 04 Oct 2013 04:55:44 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:40991) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VS1Af-0008R1-UK for 5721@debbugs.gnu.org; Fri, 04 Oct 2013 04:55:39 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MU400C00ZF2GX00@a-mtaout22.012.net.il> for 5721@debbugs.gnu.org; Fri, 04 Oct 2013 11:55:36 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MU400C6IZGNAG50@a-mtaout22.012.net.il>; Fri, 04 Oct 2013 11:55:36 +0300 (IDT) In-reply-to: <874n8xh23i.fsf@hochschule-trier.de> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78918 Archived-At: > From: Andreas Politz > Cc: jan.h.d@swipnet.se, 5721@debbugs.gnu.org > Date: Fri, 04 Oct 2013 10:28:17 +0200 > > >> Should these functions (`window-absolute-pixel-edges' and > >> `window-inside-absolute-pixel-edges') return nil in a terminal ? > > > > I see no reason to do that. We do support pixel coordinates on a text > > terminal, counting each column and row as one pixel. > > Then they should probably return the same values as the non-absolute > counterparts. Yes, this sounds correct, thanks. One more nit, about these fragments: > + #ifdef HAVE_WINDOW_SYSTEM > static void > ! calc_absolute_offset (struct frame *f, int *add_x, int *add_y) > { > ! eassert (FRAME_WINDOW_P (f)); > ! > *add_y = f->top_pos; > + #ifdef HAVE_X_WINDOWS > + *add_y += FRAME_X_OUTPUT (f)->y_pixels_outer_diff; > + #elif defined (HAVE_NTGUI) > + *add_y += f->y_pixels_diff; > + #endif > #ifdef FRAME_MENUBAR_HEIGHT > *add_y += FRAME_MENUBAR_HEIGHT (f); > #endif > *************** > *** 951,961 **** > --- 958,975 ---- > #ifdef FRAME_NS_TITLEBAR_HEIGHT > *add_y += FRAME_NS_TITLEBAR_HEIGHT (f); > #endif > + > *add_x = f->left_pos; > + #ifdef HAVE_X_WINDOWS > + *add_x += FRAME_X_OUTPUT (f)->x_pixels_outer_diff; > + #elif defined (HAVE_NTGUI) > + *add_x += f->x_pixels_diff; > + #endif > #ifdef FRAME_TOOLBAR_LEFT_WIDTH > *add_x += FRAME_TOOLBAR_LEFT_WIDTH (f); > #endif > } > + #endif /* HAVE_WINDOW_SYSTEM */ For the possibility that the same Emacs session can support several different types of frames, it is better to check the frame type at run time, not just rely on compile-time conditional. Like this: #ifdef HAVE_X_WINDOWS if (FRAME_X_P (f)) *add_y += FRAME_X_OUTPUT (f)->y_pixels_outer_diff; else #elif defined (HAVE_NTGUI) if (FRAME_W32_P (f)) *add_y += f->y_pixels_diff; #endif etc., you get the idea. The above will work if the same session can have both X and w32 frames, something that is currently impossible (AFAIK), but is not unimaginable in principle.