unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 19824@debbugs.gnu.org
Subject: bug#19824: 25.0.50; Support goal column in multi-line minibuffer
Date: Tue, 10 Feb 2015 17:57:02 +0200	[thread overview]
Message-ID: <837fvp92up.fsf@gnu.org> (raw)
In-Reply-To: <871tlyppaq.fsf@mail.linkov.net>

> From: Juri Linkov <juri@linkov.net>
> Date: Tue, 10 Feb 2015 02:45:33 +0200
> 
> In the single-line minibuffer the goal column was handled by using the point's
> absolute position that is the same as the column on the single line.
> However, this doesn't work on the multi-line minibuffer.  This patch adds
> support for the goal column on multi-line input in the minibuffer:

Thanks.

> -  (let ((old-point (point)))
> +  (let* ((old-point (point))
> +	 ;; Remember the original goal column of possibly multi-line input
> +	 ;; excluding the length of the prompt on the first line.
> +	 (prompt-end (minibuffer-prompt-end))
> +	 (old-column (unless (and (eolp) (> (point) prompt-end))
> +		       (if (= (line-number-at-pos) 1)
> +			   (max (- (current-column) (1- prompt-end)) 0)
> +			 (current-column)))))

Why do you use current-column and move-to-column here, instead of
using the line-move-visual methods we use by default in any other
buffer?  Is there some technical problem to use visual-line movement
in the minibuffer?  If not, I think we should do that for consistency
of the user experience.





  reply	other threads:[~2015-02-10 15:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10  0:45 bug#19824: 25.0.50; Support goal column in multi-line minibuffer Juri Linkov
2015-02-10 15:57 ` Eli Zaretskii [this message]
2015-02-10 23:38   ` Juri Linkov
2015-02-11 15:39     ` Eli Zaretskii
2015-02-12  0:54       ` Juri Linkov
2015-03-12 20:27 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837fvp92up.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=19824@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).