From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20154: 25.0.50; json-encode-string is too slow for large strings Date: Sat, 21 Mar 2015 10:07:22 +0200 Message-ID: <837fuavkn9.fsf@gnu.org> References: <86twxf68zk.fsf@yandex.ru> <83384zwxdx.fsf@gnu.org> <550C3218.4000903@yandex.ru> <831tkjww0y.fsf@gnu.org> <550C3AB9.7020403@yandex.ru> <83wq2bveq6.fsf@gnu.org> <550C491A.6000909@yandex.ru> <83siczvcss.fsf@gnu.org> <550C504A.10708@yandex.ru> <83r3sjva0q.fsf@gnu.org> <550C6A06.6040203@yandex.ru> <83fv8zv0b1.fsf@gnu.org> <550C9E7B.4060907@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1426925310 4305 80.91.229.3 (21 Mar 2015 08:08:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Mar 2015 08:08:30 +0000 (UTC) Cc: 20154@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 21 09:08:18 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YZES1-0007LH-OD for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Mar 2015 09:08:10 +0100 Original-Received: from localhost ([::1]:46952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZES0-0007cq-J9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Mar 2015 04:08:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZERx-0007cj-Bt for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 04:08:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZERu-0003Hh-3O for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 04:08:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41539) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZERu-0003Hd-0G for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 04:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YZERt-00055Y-Kj for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 04:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Mar 2015 08:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20154-submit@debbugs.gnu.org id=B20154.142692525519521 (code B ref 20154); Sat, 21 Mar 2015 08:08:01 +0000 Original-Received: (at 20154) by debbugs.gnu.org; 21 Mar 2015 08:07:35 +0000 Original-Received: from localhost ([127.0.0.1]:59548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZERT-00054n-97 for submit@debbugs.gnu.org; Sat, 21 Mar 2015 04:07:35 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:61004) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZERN-00054T-GD for 20154@debbugs.gnu.org; Sat, 21 Mar 2015 04:07:33 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NLJ00J00Y7XAM00@a-mtaout22.012.net.il> for 20154@debbugs.gnu.org; Sat, 21 Mar 2015 10:07:23 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NLJ00J1DYKA0OA0@a-mtaout22.012.net.il>; Sat, 21 Mar 2015 10:07:23 +0200 (IST) In-reply-to: <550C9E7B.4060907@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100734 Archived-At: > Date: Sat, 21 Mar 2015 00:26:03 +0200 > From: Dmitry Gutov > CC: 20154@debbugs.gnu.org > > As per your comment, this seems to be the best we can do for long > strings, without diving into C: > > (defun json-encode-string-1 (string) > "Return a JSON representation of STRING." > (with-temp-buffer > (insert string) > (goto-char (point-min)) > ;; Skip over ASCIIish printable characters. > (while (re-search-forward "\\([\"\\/\b\f\n\r\t]\\)\\|[^ -~]" nil t) > (replace-match > (if (match-beginning 1) > ;; Special JSON character (\n, \r, etc.). > (format "\\%c" (char-after (match-beginning 0))) Do you really need 'format' here? Why not (concat "\\" (char-to-string (char-after (match-beginning 0)))) instead? Or even simply insert these two parts at the match point, after deleting the match.