unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ivan Andrus <darthandrus@gmail.com>
Cc: 21685@debbugs.gnu.org
Subject: bug#21685: 25.0.50; [NS] Images not loading
Date: Mon, 19 Oct 2015 16:17:19 +0300	[thread overview]
Message-ID: <837fmjgfq8.fsf@gnu.org> (raw)
In-Reply-To: <1A58A649-8572-4477-9F36-8B4125C6882F@gmail.com>

> From: Ivan Andrus <darthandrus@gmail.com>
> Date: Wed, 14 Oct 2015 23:09:28 -0600
> Cc: 21685@debbugs.gnu.org
> 
> > On Oct 14, 2015, at 8:39 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > 
> >> Date: Wed, 14 Oct 2015 14:43:51 -0600
> >> From: Ivan Andrus <darthandrus@gmail.com>
> >> 
> >> Reading openp, I'm confused.  The documentation says it returns -2
> >> if the file is remote, but it seems to actually be checking if
> >> `find-file-name-handler' returns non-nil.  In particular, images
> >> return `image-file-handler', so at the very least the documentation
> >> seems wrong.
> > 
> > The practical meaning of "remote" in Emacs means exactly that: the
> > file name has a non-nil handler.  So the documentation is not wrong,
> > just confusing if you don't keep this definition in mind.
> > 
> > (I'm not saying that the above explains or invalidates your bug
> > report.)
> 
> I bisected and indeed 636736861688abe73cc5dd4181fdb66de3fd8cfd is the
> first bad commit.
> 
> However, I also noticed that emacs -Q does not exhibit the problem
> because file-name-handler-alist does not have an entry for images.  So I
> must be loading some package whichs adds a handler for images.  In fact,
> if I turn off auto-image-file-mode, images appear as I expect.

OK, thanks for the detailed analysis.  I think I fixed this on master,
please try.





  reply	other threads:[~2015-10-19 13:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 20:43 bug#21685: 25.0.50; [NS] Images not loading Ivan Andrus
2015-10-15  2:39 ` Eli Zaretskii
2015-10-15  5:09   ` Ivan Andrus
2015-10-19 13:17     ` Eli Zaretskii [this message]
     [not found]       ` <CA+R1CowBrcHGx=iptFLKXG+gTs-CX3AZM++xJKkAfZi-kYZ95w@mail.gmail.com>
2015-10-20 16:14         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837fmjgfq8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=21685@debbugs.gnu.org \
    --cc=darthandrus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).