From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 20787@debbugs.gnu.org, JFTrudeau@aetna.com
Subject: bug#20787: 24.3; make-mode doesn't hightlight macro assignments preceeded by a TAB
Date: Tue, 23 Feb 2016 18:16:45 +0200 [thread overview]
Message-ID: <837fhvjtaq.fsf@gnu.org> (raw)
In-Reply-To: <87k2lvu4dk.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 23 Feb 2016 21:07:19 +1100)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Tue, 23 Feb 2016 21:07:19 +1100
> Cc: 20787@debbugs.gnu.org
>
> "John F. Trudeau" <JFTrudeau@aetna.com> writes:
>
> > The constant makefile-macroassign-regex (used for highlighting), in
> > make-mode.el, does not find an assignment that is preceded by a TAB
> > character. The attached patch corrects the regular expression to allow
> > TAB as well as SPACE before an assignment, which corrects highlighting.
> >
> > -rw-r--r-- trudeajo/users 158 ChangeLog
> > -rw-r--r-- trudeajo/users 2101 make-mode.el.patch
> >
> > This bug has endured through many emacs releases.
>
> I've detarred the patch and included it below, but I can't really say
> whether it makes sense or not. Anybody?
LGTM, thanks.
next prev parent reply other threads:[~2016-02-23 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 19:52 bug#20787: 24.3; make-mode doesn't hightlight macro assignments preceeded by a TAB John F. Trudeau
2016-02-23 10:07 ` Lars Ingebrigtsen
2016-02-23 16:16 ` Eli Zaretskii [this message]
2016-02-23 18:21 ` Trudeau, John
2016-02-24 1:21 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837fhvjtaq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=20787@debbugs.gnu.org \
--cc=JFTrudeau@aetna.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).