From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 23779@debbugs.gnu.org
Subject: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env
Date: Fri, 17 Jun 2016 10:11:58 +0300 [thread overview]
Message-ID: <837fdocmrl.fsf@gnu.org> (raw)
In-Reply-To: <CAM-tV-_EBfqQPE0taL7=EyxV3Z_tvzBsu+3FKeYtpQSqvTj7Vw@mail.gmail.com> (message from Noam Postavsky on Thu, 16 Jun 2016 23:33:02 -0400)
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Thu, 16 Jun 2016 23:33:02 -0400
>
> (check-env-var "SHELL");=>"SHELL=/bin/bash"
> (let ((process-environment (copy-sequence process-environment)))
> (setenv "SHELL" nil)
> (check-env-var "SHELL"));=>nil
> (let ((process-environment (cons "SHELL" process-environment)))
> (check-env-var "SHELL"));=>"SHELL=/bin/bash"
> (let ((process-environment (cons "SHELL=" process-environment)))
> (check-env-var "SHELL"));=>"SHELL="
>
> As you can see from the 3rd expression, contrary to its docstring,
> consing the env variable "SHELL" onto process-environment has no
> effect at all.
>
> process-environment is a variable defined in ‘C source code’.
> Its value is
> [...]
> Documentation:
> List of overridden environment variables for subprocesses to inherit.
> Each element should be a string of the form ENVVARNAME=VALUE.
>
> Entries in this list take precedence to those in the frame-local
> environments. Therefore, let-binding ‘process-environment’ is an easy
> way to temporarily change the value of an environment variable,
> irrespective of where it comes from. To use ‘process-environment’ to
> remove an environment variable, include only its name in the list,
> without "=VALUE".
Where does it say that you can use 'cons' or 'push', and only them, to
the effect of removing the variable from the environment passed to
child processes? process-environment is just a simple list, so these
two functions just _add_ another member to the list, they don't remove
the old member.
My reading of the last sentence you cite is that you must manually
remove the old member "SHELL=whatever", and _then_ add a member that
has no value.
Am I missing something?
next prev parent reply other threads:[~2016-06-17 7:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 3:33 bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env Noam Postavsky
2016-06-17 7:11 ` Eli Zaretskii [this message]
2016-06-17 12:17 ` Dmitry Gutov
2016-06-17 14:01 ` Eli Zaretskii
2016-06-17 14:12 ` Dmitry Gutov
2016-06-17 14:19 ` Eli Zaretskii
2016-06-17 14:47 ` Dmitry Gutov
2016-06-17 16:52 ` Andreas Schwab
2016-06-17 16:55 ` Dmitry Gutov
2016-06-17 17:06 ` Eli Zaretskii
2016-06-17 19:01 ` Dmitry Gutov
2016-06-17 20:10 ` Eli Zaretskii
2016-06-17 21:26 ` Dmitry Gutov
2016-06-18 7:51 ` Eli Zaretskii
2016-06-18 1:36 ` Noam Postavsky
2016-06-18 1:44 ` Dmitry Gutov
2016-06-19 2:27 ` Paul Eggert
2016-06-19 15:01 ` Eli Zaretskii
2016-06-19 22:53 ` Paul Eggert
2016-06-20 14:21 ` Eli Zaretskii
2016-06-21 13:53 ` Dmitry Gutov
2016-06-21 15:21 ` Eli Zaretskii
2016-06-21 15:24 ` Dmitry Gutov
2016-06-21 16:12 ` Eli Zaretskii
2016-06-21 23:05 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837fdocmrl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23779@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).