From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <f92capac@gmail.com>
Cc: f92capac@gmail.com, 23823@debbugs.gnu.org
Subject: bug#23823: 25.0.95; Reset between highlight buffer/file comparisons
Date: Fri, 24 Jun 2016 10:07:11 +0300 [thread overview]
Message-ID: <837fdf2hgg.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1606241328430.19272@calancha-pc> (message from Tino Calancha on Fri, 24 Jun 2016 13:36:17 +0900 (JST))
> From: Tino Calancha <f92capac@gmail.com>
> Date: Fri, 24 Jun 2016 13:36:17 +0900 (JST)
> cc: Tino Calancha <f92capac@gmail.com>, 23823@debbugs.gnu.org
>
> >> My point is: why don't we perform a fresh comparison in 2?
> >
> > Because the first time you call highlight-compare-with-file, it turns
> > on the highlight-changes-mode, which begins to mark changes, including
> > the replacement of 'b' with 'f'.
> Yeah, that sounds nice to me: the user is still somehow in the context
> of the first func. call.
>
>
> > Why does it make sense to forget all that information?
> Because the user called the function again: this may start a new context,
> i.e., reset the minor mode in that buffer.
But the function's doc string clearly makes that expected behavior:
If the current buffer is visiting the file being compared against, it
also will have its differences highlighted.
The only way I can interpret that "also" part is that the changes
against the file are highlighted _in_addition_ to the changes tracked
by the mode. Your scenario just happens to produce a clash between
these two sets of differences, and the result could be ambiguous. But
what we get in fact doesn't seem unreasonable to me.
> I imagine buf-a becaming a mess of colors with all those changes around.
> At some point the user may want to compare again the current status of
> buf-a with file-b.
Well, then maybe a prefix argument to that effect could provide this
as an optional behavior?
next prev parent reply other threads:[~2016-06-24 7:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 10:11 bug#23823: 25.0.95; Reset between highlight buffer/file comparisons Tino Calancha
[not found] ` <handler.23823.B.14665903065838.ack@debbugs.gnu.org>
2016-06-22 10:22 ` bug#23823: Acknowledgement (25.0.95; Reset between highlight buffer/file comparisons) Tino Calancha
2016-06-22 15:16 ` bug#23823: 25.0.95; Reset between highlight buffer/file comparisons Eli Zaretskii
2016-06-23 0:46 ` Tino Calancha
2016-06-23 15:24 ` Eli Zaretskii
2016-06-24 4:36 ` Tino Calancha
2016-06-24 7:07 ` Eli Zaretskii [this message]
2016-06-24 13:13 ` Tino Calancha
2019-06-25 12:25 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837fdf2hgg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23823@debbugs.gnu.org \
--cc=f92capac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).