From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25086: [PATCH] Fix the timezone detection of parse-iso8601-time-string. Date: Sat, 17 Dec 2016 16:58:06 +0200 Message-ID: <837f6y7gch.fsf@gnu.org> References: <1480650408-26252-1-git-send-email-hong@topbug.net> <874m2nyog6.fsf@topbug.net> <8737i7yo27.fsf@topbug.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1481986749 28373 195.159.176.226 (17 Dec 2016 14:59:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Dec 2016 14:59:09 +0000 (UTC) Cc: 25086@debbugs.gnu.org To: Hong Xu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 17 15:59:05 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIGS1-0006n7-DL for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Dec 2016 15:59:05 +0100 Original-Received: from localhost ([::1]:36957 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIGS5-00049j-Ot for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Dec 2016 09:59:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIGRz-00043W-3D for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2016 09:59:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cIGRy-0004rZ-Ar for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2016 09:59:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57939) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cIGRy-0004rV-7g for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2016 09:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cIGRx-00072o-UU for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2016 09:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2016 14:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25086 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25086-submit@debbugs.gnu.org id=B25086.148198673727066 (code B ref 25086); Sat, 17 Dec 2016 14:59:01 +0000 Original-Received: (at 25086) by debbugs.gnu.org; 17 Dec 2016 14:58:57 +0000 Original-Received: from localhost ([127.0.0.1]:45105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIGRs-00072U-Us for submit@debbugs.gnu.org; Sat, 17 Dec 2016 09:58:57 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:50291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIGRq-00072G-SC for 25086@debbugs.gnu.org; Sat, 17 Dec 2016 09:58:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cIGRg-0004nn-QL for 25086@debbugs.gnu.org; Sat, 17 Dec 2016 09:58:49 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIGRg-0004nj-NW; Sat, 17 Dec 2016 09:58:44 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3727 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cIGRf-0003dW-Sr; Sat, 17 Dec 2016 09:58:44 -0500 In-reply-to: <8737i7yo27.fsf@topbug.net> (message from Hong Xu on Thu, 01 Dec 2016 20:04:00 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127107 Archived-At: > From: Hong Xu > Date: Thu, 01 Dec 2016 20:04:00 -0800 > > +;;;###autoload > (defun parse-iso8601-time-string (date-string) > + "Parse an ISO 8601 time string, such as 2016-12-01T23:35:06-05:00. > +If DATE-STRING cannot be parsed, it falls back to > +`parse-time-string'." Why did you want to autoload this? The log message doesn't mention this change at all. > + '(42 35 19 22 2 2016 1 t -25200))) > + (should (equal (parse-iso8601-time-string "1998-09-12T12:21:54-0200") > + '(13818 33666))) > + (should (equal (parse-iso8601-time-string "1998-09-12T12:21:54-02:00") > + '(13818 33666))) > + (should (equal (parse-iso8601-time-string "1998-09-12T12:21:54-02") > + '(13818 33666))) > + (should (equal (parse-iso8601-time-string "1998-09-12T12:21:54+02") > + '(13818 19266)))) Does this also test this part of your changes: > @@ -204,13 +204,17 @@ parse-time-iso8601-regexp > (date-time (concat full-date "T" full-time))) > (list (concat "^" full-date) > (concat "T" partial-time) > - (concat "Z" time-numoffset))) > + (concat "Z?" time-numoffset))) If not, could you please add tests for that? Thanks.