From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for CASECHARS in built-in dictionaries Date: Tue, 20 Dec 2016 17:37:58 +0200 Message-ID: <837f6u4nmx.fsf@gnu.org> References: <831sx36g75.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1482248352 27695 195.159.176.226 (20 Dec 2016 15:39:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Dec 2016 15:39:12 +0000 (UTC) Cc: 25230@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 20 16:39:08 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJMVQ-0006Ru-2J for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Dec 2016 16:39:08 +0100 Original-Received: from localhost ([::1]:51923 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJMVU-00038t-F3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Dec 2016 10:39:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJMVL-00037f-Hs for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2016 10:39:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJMVK-0004rX-Nc for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2016 10:39:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33730) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cJMVK-0004rT-KH for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2016 10:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cJMVK-00041V-CC for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2016 10:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Dec 2016 15:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25230-submit@debbugs.gnu.org id=B25230.148224829215389 (code B ref 25230); Tue, 20 Dec 2016 15:39:02 +0000 Original-Received: (at 25230) by debbugs.gnu.org; 20 Dec 2016 15:38:12 +0000 Original-Received: from localhost ([127.0.0.1]:49129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJMUV-000409-Nz for submit@debbugs.gnu.org; Tue, 20 Dec 2016 10:38:11 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJMUU-0003zs-8a for 25230@debbugs.gnu.org; Tue, 20 Dec 2016 10:38:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJMUL-0004cB-Qf for 25230@debbugs.gnu.org; Tue, 20 Dec 2016 10:38:04 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJMUL-0004c7-NH; Tue, 20 Dec 2016 10:38:01 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2955 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cJMUL-0001w9-1R; Tue, 20 Dec 2016 10:38:01 -0500 In-reply-to: (message from Reuben Thomas on Mon, 19 Dec 2016 21:17:17 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127238 Archived-At: > From: Reuben Thomas > Date: Mon, 19 Dec 2016 21:17:17 +0000 > Cc: 25230@debbugs.gnu.org > > You are assuming that [[:alpha:]] and [A-Za-z] are identical. > > ​No, because my patch does not change the current behaviour of the code. The assumption that [:alpha:] is OK to use here instead of A-Za-z is already in the code.​ Can you point out where in the code you see that assumption? > ​From the conversation on other bugs, I think that the correct thing to do here is to remove the first part of my patch (so that the hardwired dictionaries keep their individual casechars and not-casechars settings), and keep the second part of the patch (so that ispell-set-spellchecker-params does not change them all to [:alpha:]. > > Does that sound plausible? I think so, but we should make sure the hard-wired values work with Aspell, before we make that change. If they don't, we should provide something that works for Aspell.