From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#26961: 26.0.50; Possible timming issue in regex-tests.el Date: Fri, 19 May 2017 10:14:03 +0300 Message-ID: <837f1d48uc.fsf@gnu.org> References: <87inkz23aw.fsf@calancha-pc> <878tlvy4d4.fsf@calancha-pc> <83bmqr5trb.fsf@gnu.org> <874lwi3b00.fsf@calancha-pc> <83ziea4358.fsf@gnu.org> <87h90hwmip.fsf@calancha-pc> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1495178110 4051 195.159.176.226 (19 May 2017 07:15:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 19 May 2017 07:15:10 +0000 (UTC) Cc: 26961@debbugs.gnu.org, schwab@suse.de To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 19 09:15:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBc7t-0000x8-RT for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 May 2017 09:15:05 +0200 Original-Received: from localhost ([::1]:56952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBc7z-0002Zs-Fj for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 May 2017 03:15:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBc7t-0002YH-IG for bug-gnu-emacs@gnu.org; Fri, 19 May 2017 03:15:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBc7q-0006Tl-Cv for bug-gnu-emacs@gnu.org; Fri, 19 May 2017 03:15:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51608) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dBc7q-0006TC-9j for bug-gnu-emacs@gnu.org; Fri, 19 May 2017 03:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dBc7p-0006Ia-Uk for bug-gnu-emacs@gnu.org; Fri, 19 May 2017 03:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 May 2017 07:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26961 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26961-submit@debbugs.gnu.org id=B26961.149517806224144 (code B ref 26961); Fri, 19 May 2017 07:15:01 +0000 Original-Received: (at 26961) by debbugs.gnu.org; 19 May 2017 07:14:22 +0000 Original-Received: from localhost ([127.0.0.1]:54285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBc7C-0006HM-7Z for submit@debbugs.gnu.org; Fri, 19 May 2017 03:14:22 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBc7B-0006HA-GY for 26961@debbugs.gnu.org; Fri, 19 May 2017 03:14:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBc75-0006H6-Ke for 26961@debbugs.gnu.org; Fri, 19 May 2017 03:14:16 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBc6z-0006Fo-At; Fri, 19 May 2017 03:14:09 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3248 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dBc6y-0000lH-I3; Fri, 19 May 2017 03:14:08 -0400 In-reply-to: <87h90hwmip.fsf@calancha-pc> (message from Tino Calancha on Fri, 19 May 2017 12:31:10 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132624 Archived-At: > From: Tino Calancha > Cc: Andreas Schwab , Eli Zaretskii > Date: Fri, 19 May 2017 12:31:10 +0900 > > Following diff hunk from commit > 'Improve unescaped character literal warnings' > (16004397f4) > seems the origin of the problem: those lists with > defsym's in their heads. > > diff --git a/src/lread.c b/src/lread.c > --- a/src/lread.c > +++ b/src/lread.c > @@ -963,9 +963,11 @@ load_warn_unescaped_character_literals (Lisp_Object file) > AUTO_STRING (format, > "Loading `%s': unescaped character literals %s detected!"); > AUTO_STRING (separator, ", "); > + AUTO_STRING (inner_format, "`?%c'"); > CALLN (Fmessage, > format, file, > - Fmapconcat (Qstring, > + Fmapconcat (list3 (Qlambda, list1 (Qchar), > + list3 (Qformat, inner_format, Qchar)), > Fsort (Vlread_unescaped_character_literals, Qlss), > separator)); > } > > Do you think this code is wrong? This does indeed look dangerous: we are in effect consing Lisp data structures from stack-based Lisp objects, and then process them in a way that could leave some of them lying around when this function returns, and its stack becomes invalid. Can you present the evidence that caused you to suspect this particular change? Were the "unescaped character literals" warning displayed during the session which crashed?