From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30004: 27.0.50; call-interactively reads uninitialized memory Date: Sat, 06 Jan 2018 17:56:06 +0200 Message-ID: <837esv9e21.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1515254183 31774 195.159.176.226 (6 Jan 2018 15:56:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 6 Jan 2018 15:56:23 +0000 (UTC) Cc: 30004@debbugs.gnu.org To: Philipp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 06 16:56:19 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXqpO-0007M5-CA for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jan 2018 16:56:10 +0100 Original-Received: from localhost ([::1]:40276 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXqrM-0006jQ-6V for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jan 2018 10:58:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXqqG-0005fT-TI for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 10:57:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXqqE-000843-As for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 10:57:04 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57862) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eXqqE-00083o-6e for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 10:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eXqqD-0006IQ-TC for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 10:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jan 2018 15:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30004 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30004-submit@debbugs.gnu.org id=B30004.151525419924172 (code B ref 30004); Sat, 06 Jan 2018 15:57:01 +0000 Original-Received: (at 30004) by debbugs.gnu.org; 6 Jan 2018 15:56:39 +0000 Original-Received: from localhost ([127.0.0.1]:38310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXqpp-0006Hn-O8 for submit@debbugs.gnu.org; Sat, 06 Jan 2018 10:56:38 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXqpm-0006HY-6l for 30004@debbugs.gnu.org; Sat, 06 Jan 2018 10:56:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXqpe-0007g2-De for 30004@debbugs.gnu.org; Sat, 06 Jan 2018 10:56:28 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXqpe-0007fn-AI; Sat, 06 Jan 2018 10:56:26 -0500 Original-Received: from [176.228.60.248] (port=2657 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eXqpd-0008NF-BV; Sat, 06 Jan 2018 10:56:26 -0500 In-reply-to: (message from Philipp on Sat, 06 Jan 2018 12:31:51 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141838 Archived-At: > From: Philipp > Date: Sat, 06 Jan 2018 12:31:51 +0100 > > When passing a byte that would start a multibyte sequence, > `call-interactively` uses STRING_CHAR without checking whether the > entire multibyte sequence is actually part of the string. For example: > > $ emacs -batch -nw -Q -eval '(call-interactively (lambda () (interactive "\xFF")))' > Invalid control letter ‘𿯾’ (#o775776, #x3fbfe) in interactive calling string Thanks for catching this. Does the patch below fix this? diff --git a/src/callint.c b/src/callint.c index ef22851..ede9a02 100644 --- a/src/callint.c +++ b/src/callint.c @@ -774,10 +774,18 @@ invoke it. If KEYS is omitted or nil, the return value of if anyone tries to define one here. */ case '+': default: - error ("Invalid control letter `%c' (#o%03o, #x%04x) in interactive calling string", - STRING_CHAR ((unsigned char *) tem), - (unsigned) STRING_CHAR ((unsigned char *) tem), - (unsigned) STRING_CHAR ((unsigned char *) tem)); + { + ptrdiff_t bytes_left = SBYTES (specs) - (tem - string); + unsigned letter; + + if (bytes_left >= BYTES_BY_CHAR_HEAD (*((unsigned char *) tem))) + letter = STRING_CHAR ((unsigned char *) tem); + else + letter = *((unsigned char *) tem); + + error ("Invalid control letter `%c' (#o%03o, #x%04x) in interactive calling string", + (int) letter, letter, letter); + } } if (varies[i] == 0)