From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30491: 26.0; (elisp) `Profiling' Date: Sat, 17 Feb 2018 12:06:06 +0200 Message-ID: <837ercc4mp.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1518861923 23089 195.159.176.226 (17 Feb 2018 10:05:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Feb 2018 10:05:23 +0000 (UTC) Cc: 30491@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 17 11:05:18 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emzMq-0005WO-So for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Feb 2018 11:05:17 +0100 Original-Received: from localhost ([::1]:60104 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emzOr-0000R1-9a for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Feb 2018 05:07:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emzOg-0000QG-Mc for bug-gnu-emacs@gnu.org; Sat, 17 Feb 2018 05:07:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emzOd-0001cq-IG for bug-gnu-emacs@gnu.org; Sat, 17 Feb 2018 05:07:10 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39587) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emzOY-0001cE-0F for bug-gnu-emacs@gnu.org; Sat, 17 Feb 2018 05:07:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1emzOX-0005hh-Pz for bug-gnu-emacs@gnu.org; Sat, 17 Feb 2018 05:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Feb 2018 10:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30491 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30491-submit@debbugs.gnu.org id=B30491.151886197721856 (code B ref 30491); Sat, 17 Feb 2018 10:07:01 +0000 Original-Received: (at 30491) by debbugs.gnu.org; 17 Feb 2018 10:06:17 +0000 Original-Received: from localhost ([127.0.0.1]:47484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emzNo-0005gS-On for submit@debbugs.gnu.org; Sat, 17 Feb 2018 05:06:16 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emzNm-0005gB-MC for 30491@debbugs.gnu.org; Sat, 17 Feb 2018 05:06:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emzNe-0001Nn-6v for 30491@debbugs.gnu.org; Sat, 17 Feb 2018 05:06:09 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51048) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emzNe-0001Nh-3S; Sat, 17 Feb 2018 05:06:06 -0500 Original-Received: from [176.228.60.248] (port=3381 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1emzNd-0003fo-8p; Sat, 17 Feb 2018 05:06:05 -0500 In-reply-to: (message from Drew Adams on Fri, 16 Feb 2018 10:11:59 -0800 (PST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143365 Archived-At: > Date: Fri, 16 Feb 2018 10:11:59 -0800 (PST) > From: Drew Adams > > 1. "how much resource" is not good English. How much of a given > resource or how many resources, not how much resource. "Resource" is > a countable noun. > > 2. "See the functions 'benchmark-run' and 'benchmark-run-compiled'". > Those are macros, not functions. And it should probably mention > command `benchmark'. I fixed those. > 3. The node should say something about library `elp', or it should not > mention it. The approach should be similar to what is said about > library `benchmark.el', at a minimum. Done. > 4. A simple example of using the profiler commands would be welcome. Not sure what example you had in mind. The text mentions 3 profiler commands to invoke, and describes the resulting profile. What would the example include, besides just "M-x profile-start" etc., which sounds redundant? > Also, some brief comparison of profile, elp, and benchmark could be helpful: what are their particular purposes, strengths, etc. I think this was already clear from the text: e.g., benchmark only measures the total execution time of a form, it doesn't produce any insights on the distribution of that time between the form's components. I added more text to make some differences more clear. Thanks.