bug#31020: 27.0; Please provide a way to know about menu-bar wrapping

bug#31020: 27.0; Please provide a way to know about menu-bar wrapping

[Drew Adams]

Enhancement request.

When a frame is narrower than the text in the
menu-bar, that text is wrapped.  And yet the value of frame parameter
`menu-bar-lines' is not increased (which is good).

It would be good to be able to know (from Elisp) how many "visual"
(effective) menu-bar lines there are currently, that is, how many times
the menu-bar text is wrapped.  (It is typically wrapped zero or one
time, producing text that appears visually to be two lines.)


In GNU Emacs 27.0.50 (build 3, x86_64-w64-mingw32)
 of 2018-03-21
Repository revision: e70d0c9e66d7a8609450b2889869d16aeb0363b5
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install -C 'CFLAGS=-O2 -static -g3''

bug#31020: 27.0; Please provide a way to know about menu-bar wrapping

[Eli Zaretskii]

> Date: Sun, 1 Apr 2018 20:03:00 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
> 
> When a frame is narrower than the text in the
> menu-bar, that text is wrapped.  And yet the value of frame parameter
> `menu-bar-lines' is not increased (which is good).
> 
> It would be good to be able to know (from Elisp) how many "visual"
> (effective) menu-bar lines there are currently, that is, how many times
> the menu-bar text is wrapped.  (It is typically wrapped zero or one
> time, producing text that appears visually to be two lines.)

I don't understand why you think that the menu-bar-lines parameter
should not be it.  AFAIU, the problem with setting it (or any other
frame parameter) to the actual value is that with many toolkits Emacs
simply doesn't know the correct value.  But maybe Martin will have
some trick up his sleeves.

bug#31020: 27.0; Please provide a way to know about menu-bar wrapping

[martin rudalics]

 > I don't understand why you think that the menu-bar-lines parameter
 > should not be it.  AFAIU, the problem with setting it (or any other
 > frame parameter) to the actual value is that with many toolkits Emacs
 > simply doesn't know the correct value.  But maybe Martin will have
 > some trick up his sleeves.

I am not aware of any toolkit telling us that number or whether the
current menu bar was wrapped at all.  It's nowhere in the various API
descriptions and I suppose the information usually gets lost somewhere
in between calculations of which font the user's theme wants for the
menu bar and how that affects wrapping.  I'm not even sure whether
some toolkit would deliberately truncate our menu bar when it doesn't
fit into one line.  And lets not talk about GTK auto-resizing our
frame when the menu bar gets too long.

So what you can do is the following: Make a frame with a _visibly
unwrapped_ menu bar, get the menu bar height via

(cddr (assq 'menu-bar-size (frame-geometry)))

Do the same for a frame with a _visibly wrapped_ two-lines menu bar.
You can now derive the height of the single-line and any additional
menu bar line and use these values together with 'frame-geometry' for
getting the actual number of lines.

Obviously, this will work only as long as you do not change themes,
the menu bar height of the current theme or the resolution of your
screen or whatever else could affect this.  And since you have to
visuallly check the "wrappedness" of the menu bar, this work cannot be
reasonably done from within Emacs.

martin

bug#31020: 27.0; Please provide a way to know about menu-bar wrapping

[Drew Adams]

> So what you can do is the following: Make a frame with a _visibly
> unwrapped_ menu bar, get the menu bar height via
> (cddr (assq 'menu-bar-size (frame-geometry)))
> 
> Do the same for a frame with a _visibly wrapped_ two-lines menu bar.
> You can now derive the height of the single-line and any additional
> menu bar line and use these values together with 'frame-geometry' for
> getting the actual number of lines.

That's good to know; thanks.  But I don't think it will
help code that has only a given frame to examine, e.g.,
code that doesn't want to bother some user by creating
or resizing frames to determine this.  And anyway, the
_code_ cannot, by itself, tell the _visibly wrapped_
condition.

IOW, that suggestion might help a user to determine,
by looking, what the situation is.  But I don't see how
I could use in from Lisp to know what the situation is.
Let me know, if I'm missing something simple.

> Obviously, this will work only as long as you do not change themes,
> the menu bar height of the current theme or the resolution of your
> screen or whatever else could affect this.  And since you have to
> visuallly check the "wrappedness" of the menu bar, this work cannot be
> reasonably done from within Emacs.

Ah, that's just what I meant above.  Thanks for confirming.

bug#31020: 27.0; Please provide a way to know about menu-bar wrapping

[Stefan Kangas]

tags 31020 + wontfix
close 31020
quit

martin rudalics <rudalics@gmx.at> writes:

>> I don't understand why you think that the menu-bar-lines parameter
>> should not be it.  AFAIU, the problem with setting it (or any other
>> frame parameter) to the actual value is that with many toolkits Emacs
>> simply doesn't know the correct value.  But maybe Martin will have
>> some trick up his sleeves.
>
> I am not aware of any toolkit telling us that number or whether the
> current menu bar was wrapped at all.  It's nowhere in the various API
> descriptions and I suppose the information usually gets lost somewhere
> in between calculations of which font the user's theme wants for the
> menu bar and how that affects wrapping.  I'm not even sure whether
> some toolkit would deliberately truncate our menu bar when it doesn't
> fit into one line.  And lets not talk about GTK auto-resizing our
> frame when the menu bar gets too long.
>
> So what you can do is the following: Make a frame with a _visibly
> unwrapped_ menu bar, get the menu bar height via
>
> (cddr (assq 'menu-bar-size (frame-geometry)))
>
> Do the same for a frame with a _visibly wrapped_ two-lines menu bar.
> You can now derive the height of the single-line and any additional
> menu bar line and use these values together with 'frame-geometry' for
> getting the actual number of lines.
>
> Obviously, this will work only as long as you do not change themes,
> the menu bar height of the current theme or the resolution of your
> screen or whatever else could affect this.  And since you have to
> visuallly check the "wrappedness" of the menu bar, this work cannot be
> reasonably done from within Emacs.

It seems like the conclusion here is that the feature suggestion is not
practical, so I'm closing it as wontfix.

If this is incorrect, please reopen the bug.

Best regards,
Stefan Kangas

bug#31020: 27.0; Please provide a way to know about menu-bar wrapping

[Drew Adams]

> > When a frame is narrower than the text in the
> > menu-bar, that text is wrapped.  And yet the value of frame parameter
> > `menu-bar-lines' is not increased (which is good).
> >
> > It would be good to be able to know (from Elisp) how many "visual"
> > (effective) menu-bar lines there are currently, that is, how many times
> > the menu-bar text is wrapped.  (It is typically wrapped zero or one
> > time, producing text that appears visually to be two lines.)
> 
> I don't understand why you think that the menu-bar-lines parameter
> should not be it.  AFAIU, the problem with setting it (or any other
> frame parameter) to the actual value is that with many toolkits Emacs
> simply doesn't know the correct value.  But maybe Martin will have
> some trick up his sleeves.

I think it's helpful to distinguish (1) the actual,
current number of lines used, reflecting any possible
wrapping, from (2) the user's setting of how many
lines should be used for the menu-bar.

How those are distinguished doesn't matter to me so
much.

And if you decide that there is no sense in such a
distinction, and that the parameter value should be
automatically changed, dynamically, as a frame's
width is changed (e.g. to force or remove wrapping),
then that would probably be OK too.

The problem, at least on MS Windows, is that the
menu-bar wraps, and there is no way (AFAIK) to know
from Lisp who many actual lines are currently used
to show the menu-bar.

This is an old problem, as you know.  It would be
really good to finally put it to bed, if possible.

bug#31020: 27.0; Please provide a way to know about menu-bar wrapping

[martin rudalics]

 > The problem, at least on MS Windows, is that the
 > menu-bar wraps, and there is no way (AFAIK) to know
 > from Lisp who many actual lines are currently used
 > to show the menu-bar.
 >
 > This is an old problem, as you know.  It would be
 > really good to finally put it to bed, if possible.

Can you tell me one practical case where you want to know how many
lines are used to show the menu bar?

martin

bug#31020: 27.0; Please provide a way to know about menu-bar wrapping

[Drew Adams]

>  > The problem, at least on MS Windows, is that the
>  > menu-bar wraps, and there is no way (AFAIK) to know
>  > from Lisp who many actual lines are currently used
>  > to show the menu-bar.
>  >
>  > This is an old problem, as you know.  It would be
>  > really good to finally put it to bed, if possible.
> 
> Can you tell me one practical case where you want to
> know how many lines are used to show the menu bar?

Yes.  But you'll perhaps tell me to do things another
way (e.g., pixelwise). ;-)

My fit-frame.el code changes a frame's width and height
to fit the buffer text.  It also takes into account
things like `menu-bar-lines' and `tool-bar-lines'.  It
does its work using chars, i.e., lines and columns, not
pixels.

If the frame before fitting is narrow enough that the
menu-bar is wrapped, and if the frame is narrower than
its fit width (the width it will be fit to, based on
max line length), then the resulting height is slightly
greater than when the menu-bar is not wrapped.  (The
latter height is what I want.)

This has the effect that two different resulting frame
heights are possible, depending on whether the menu is
wrapped.  So the action is not idempotent if the bar is
wrapped (and the max line length is wider than the
unwrapped menu-bar width): The first `fit-frame' makes
the frame a bit taller; the second and subsequent calls
to `fit-frame' make it the right height.  (All calls
give it the right width.)

If my code could know how many _effective_ (i.e.,
visual) `menu-bar-lines' were currently present then
it would just DTRT.

HTH.

bug#31020: 27.0; Please provide a way to know about menu-bar wrapping

[martin rudalics]

 > Yes.  But you'll perhaps tell me to do things another
 > way (e.g., pixelwise). ;-)

I'm afraid that both approaches might face similar problems.

 > If my code could know how many _effective_ (i.e.,
 > visual) `menu-bar-lines' were currently present then
 > it would just DTRT.

Why don't you try to divide the value of

(cddr (assq 'menu-bar-size (frame-geometry)))

by 'frame-char-height'?  IIUC the character height used by a toolkit
for drawing the menu bar is of no use to you anyway.

But to fit a frame you (and the pixelwise fitter as well) would have
to be able to tell _in advance_ whether the menu bar will wrap.  And
this is impossible since at least on a proprietary system like Windows
you would have to know which algorithm it uses for aligning menu bar
elements.  Or am I missing something?

martin