From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: andrewjmoreton@gmail.com, 32257@debbugs.gnu.org
Subject: bug#32257: 26.1; read-multiple-choice inf loops on mouse clicks
Date: Fri, 27 Jul 2018 16:50:02 +0300 [thread overview]
Message-ID: <837elgss8l.fsf@gnu.org> (raw)
In-Reply-To: <87r2jo3l0w.fsf@gmail.com> (message from Noam Postavsky on Fri, 27 Jul 2018 08:45:03 -0400)
> From: Noam Postavsky <npostavs@gmail.com>
> Cc: Andy Moreton <andrewjmoreton@gmail.com>, 32257@debbugs.gnu.org
> Date: Fri, 27 Jul 2018 08:45:03 -0400
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Andy Moreton <andrewjmoreton@gmail.com>
> >> Date: Fri, 27 Jul 2018 12:35:27 +0100
> >>
> >> > If we want this change on emacs-26, we should carefully audit all the
> >> > other users of rmc.el
>
> What should we check for though?
Anything that read-event handles differently from read-char. Maybe a
good starting point is to compile a list of the differences in
behavior between the two.
> >> read-multiple choice only has two callers (`nsm-query-user' and
> >> `message-fix-before-sending') in both master and emacs-26.
> >
> > In Emacs, yes. But what about the world out there?
>
> I expect all the callers out in the world will exhibit the same bug.
What about the features they expect?
> At any rate, I don't see a way of fixing it in the caller, short of
> temporarily fsetting read-char into read-event.
If there's no better idea, we could copy read-multiple-choice into
nsm.el and replace read-char with read-event there. But maybe there
are more elegant ideas.
> Also, read-multiple-choice is new in Emacs 26, so it seems to me we
> should rather fix it in 26.2.
I agree, I just am not convince that replacing read-char with
read-event is the right fix.
next prev parent reply other threads:[~2018-07-27 13:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 12:05 bug#32257: 26.1; read-multiple-choice inf loops on mouse clicks Noam Postavsky
2018-07-26 1:25 ` Noam Postavsky
2018-07-27 9:08 ` Eli Zaretskii
2018-07-27 11:35 ` Andy Moreton
2018-07-27 12:30 ` Eli Zaretskii
2018-07-27 12:45 ` Noam Postavsky
2018-07-27 13:50 ` Eli Zaretskii [this message]
2018-07-31 1:52 ` Noam Postavsky
2018-07-31 11:59 ` Andy Moreton
2018-07-31 12:27 ` martin rudalics
2018-07-31 12:38 ` Andy Moreton
2018-08-01 8:44 ` martin rudalics
2018-08-01 12:30 ` Noam Postavsky
2018-08-01 12:57 ` Robert Pluim
2018-08-02 7:09 ` martin rudalics
2018-08-01 20:55 ` Live System User
2018-08-02 7:09 ` martin rudalics
2018-07-31 16:06 ` Eli Zaretskii
2018-07-31 19:26 ` Andy Moreton
2018-08-01 5:27 ` Eli Zaretskii
2018-07-31 16:04 ` Eli Zaretskii
2018-07-31 19:29 ` Andy Moreton
2018-08-01 5:29 ` Eli Zaretskii
2018-08-01 12:05 ` Andy Moreton
2019-05-22 0:52 ` Noam Postavsky
2019-05-22 10:08 ` Eli Zaretskii
2019-05-26 12:57 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837elgss8l.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32257@debbugs.gnu.org \
--cc=andrewjmoreton@gmail.com \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).