From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31039: 27.0.50; allow silencing auto-save Date: Sat, 11 Aug 2018 12:31:34 +0300 Message-ID: <837ekxmeq1.fsf@gnu.org> References: <87zhy0xliz.fsf@gmail.com> <83d0uvsfgi.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1533979812 22702 195.159.176.226 (11 Aug 2018 09:30:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 11 Aug 2018 09:30:12 +0000 (UTC) Cc: 31039-done@debbugs.gnu.org, npostavs@gmail.com, aaronjensen@gmail.com To: Federico Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 11 11:30:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1foQDn-0005os-Qe for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 Aug 2018 11:30:07 +0200 Original-Received: from localhost ([::1]:59435 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foQFt-0008Ks-Ut for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 Aug 2018 05:32:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foQFj-0008Jk-NX for bug-gnu-emacs@gnu.org; Sat, 11 Aug 2018 05:32:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foQFg-0006Fw-JR for bug-gnu-emacs@gnu.org; Sat, 11 Aug 2018 05:32:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42776) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1foQFg-0006Fo-Ff for bug-gnu-emacs@gnu.org; Sat, 11 Aug 2018 05:32:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1foQFg-0006O9-8h for bug-gnu-emacs@gnu.org; Sat, 11 Aug 2018 05:32:04 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Aug 2018 09:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 31039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 31039@debbugs.gnu.org, eliz@gnu.org, aaronjensen@gmail.com Original-Received: via spool by 31039-done@debbugs.gnu.org id=D31039.153397990324521 (code D ref 31039); Sat, 11 Aug 2018 09:32:02 +0000 Original-Received: (at 31039-done) by debbugs.gnu.org; 11 Aug 2018 09:31:43 +0000 Original-Received: from localhost ([127.0.0.1]:47793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1foQFK-0006NR-Oa for submit@debbugs.gnu.org; Sat, 11 Aug 2018 05:31:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1foQFJ-0006NF-5o for 31039-done@debbugs.gnu.org; Sat, 11 Aug 2018 05:31:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foQFA-00064z-OX for 31039-done@debbugs.gnu.org; Sat, 11 Aug 2018 05:31:35 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foQFA-00064s-Jz; Sat, 11 Aug 2018 05:31:32 -0400 Original-Received: from [176.228.60.248] (port=3200 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1foQF9-0005us-VP; Sat, 11 Aug 2018 05:31:32 -0400 In-reply-to: (message from Federico on Mon, 6 Aug 2018 20:02:28 -0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149429 Archived-At: > From: Federico > Date: Mon, 6 Aug 2018 20:02:28 -0300 > Cc: Noam Postavsky , Aaron Jensen , 31039@debbugs.gnu.org > > Noam, Eli: I've applied the fixes you have both mentioned. I ended up > using DEFVAR_BOOL to create the variable, but I'm not sure I used the > variable correctly when calling Fdo_auto_save (the function only takes > Lisp_Object). I have attached a new patch. > > Regarding the copyright assignment, mine was approved one or two weeks ago. Thanks, pushed to the master branch. A few minor nits for your future contributions: . For changes in the manuals, the name of the node where the change is done should be mentioned in parentheses, as if it were a function. . Please make sure the NEWS entries are filled according to the default setting of fill-column (use M-q to do that). . It is preferable to explicitly mention the new functions/variables in the log entries for NEWS and the manuals. You can look at the changes I actually pushed to see how I handled those issues in this commit. Thank you for your contribution; your copyright assignment is now on file.