unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Federico <federicotedin@gmail.com>
Cc: 31039-done@debbugs.gnu.org, npostavs@gmail.com, aaronjensen@gmail.com
Subject: bug#31039: 27.0.50; allow silencing auto-save
Date: Sat, 11 Aug 2018 12:31:34 +0300	[thread overview]
Message-ID: <837ekxmeq1.fsf@gnu.org> (raw)
In-Reply-To: <CAA8GjPmssG0KdBFsaxRzDBukAFt8H78Wy8nWO12BP8C6h6+xCg@mail.gmail.com> (message from Federico on Mon, 6 Aug 2018 20:02:28 -0300)

> From: Federico <federicotedin@gmail.com>
> Date: Mon, 6 Aug 2018 20:02:28 -0300
> Cc: Noam Postavsky <npostavs@gmail.com>, Aaron Jensen <aaronjensen@gmail.com>, 31039@debbugs.gnu.org
> 
> Noam, Eli: I've applied the fixes you have both mentioned. I ended up
> using DEFVAR_BOOL to create the variable, but I'm not sure I used the
> variable correctly when calling Fdo_auto_save (the function only takes
> Lisp_Object). I have attached a new patch.
> 
> Regarding the copyright assignment, mine was approved one or two weeks ago.

Thanks, pushed to the master branch.

A few minor nits for your future contributions:

  . For changes in the manuals, the name of the node where the change
    is done should be mentioned in parentheses, as if it were a
    function.
  . Please make sure the NEWS entries are filled according to the
    default setting of fill-column (use M-q to do that).
  . It is preferable to explicitly mention the new functions/variables
    in the log entries for NEWS and the manuals.

You can look at the changes I actually pushed to see how I handled
those issues in this commit.

Thank you for your contribution; your copyright assignment is now on
file.





  parent reply	other threads:[~2018-08-11  9:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03  9:06 bug#31039: 27.0.50; allow silencing auto-save Aaron Jensen
2018-08-04  0:51 ` Federico
2018-08-06  2:43   ` Noam Postavsky
2018-08-06 14:56     ` Eli Zaretskii
2018-08-06 15:05     ` Eli Zaretskii
2018-08-06 23:02       ` Federico
2018-08-07 14:54         ` Eli Zaretskii
2018-08-07 18:36           ` Federico
2018-08-11 16:10             ` Aaron Jensen
2018-08-11  9:31         ` Eli Zaretskii [this message]
2018-08-11 10:11           ` Eli Zaretskii
2018-08-11 18:20             ` Federico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837ekxmeq1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=31039-done@debbugs.gnu.org \
    --cc=aaronjensen@gmail.com \
    --cc=federicotedin@gmail.com \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).