unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Reuben Thomas <rrt@sc3d.org>
Cc: 32651@debbugs.gnu.org
Subject: bug#32651: flyspell marks doublons when not the same case
Date: Thu, 06 Sep 2018 22:34:46 +0300	[thread overview]
Message-ID: <837ejywhbd.fsf@gnu.org> (raw)
In-Reply-To: <CAOnWdohA99ZrhjPQ2-1rFV+UbzjoOkZzK0nN9cXRf8w3FSNG5w@mail.gmail.com> (message from Reuben Thomas on Thu, 6 Sep 2018 20:16:10 +0100)

> From: Reuben Thomas <rrt@sc3d.org>
> Date: Thu, 6 Sep 2018 20:16:10 +0100
> 
> Flyspell marks for example the second "AND" in "an AND split and AND join" as a duplicate.
> 
> This seems to be deliberate: in line 1153 of flyspell.el (on current emacs-26 branch)
> flyspell-word-search-backward is called with IGNORE-CASE set to t.
> 
> I don't understand this: if it's not the same case, it's probably deliberate, no?
> 
> I checked that simply removing this `t' argument makes doublon detection work as I'd expect: "AND AND",
> "and and" and "And And" are all marked as doublons, but anything that's not the same case isn't.

There are valid use cases where the current behavior is what the users
want (e.g., "And and" at the beginning of a sentence).  So we could
introduce an option to do what you want, but I don't think we can
change the default behavior unconditionally.





  reply	other threads:[~2018-09-06 19:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06 19:16 bug#32651: flyspell marks doublons when not the same case Reuben Thomas
2018-09-06 19:34 ` Eli Zaretskii [this message]
2018-09-06 19:37   ` Reuben Thomas
2018-09-06 19:53     ` Eli Zaretskii
2018-09-06 19:58       ` Reuben Thomas
2018-09-07  5:59         ` Eli Zaretskii
2018-09-07  9:49           ` Reuben Thomas
2018-09-09 19:45             ` Reuben Thomas
2018-09-09 19:54               ` Eli Zaretskii
2018-09-09 20:24                 ` Reuben Thomas
2018-09-10  6:26                   ` Eli Zaretskii
2018-09-10 14:12                     ` Reuben Thomas
2018-09-10 14:13 ` bug#32651: Installed as commit 61f3a4b4f Reuben Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837ejywhbd.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=32651@debbugs.gnu.org \
    --cc=rrt@sc3d.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).