From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33195: 27.0.50; user-login-name has no group-login-name Date: Sat, 10 Nov 2018 11:24:26 +0200 Message-ID: <837ehlb7zp.fsf@gnu.org> References: <87d0rsegbi.fsf@gmail.com> <837ehzlo3a.fsf@gnu.org> <87tvl3cmrj.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1541841794 20125 195.159.176.226 (10 Nov 2018 09:23:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Nov 2018 09:23:14 +0000 (UTC) Cc: 33195-done@debbugs.gnu.org To: Jules Tamagnan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 10 10:23:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLPTv-00053o-SB for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Nov 2018 10:23:07 +0100 Original-Received: from localhost ([::1]:37670 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLPW1-0000lf-Ul for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Nov 2018 04:25:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLPVp-0000la-NV for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 04:25:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLPVm-0001oZ-F3 for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 04:25:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39900) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gLPVm-0001oO-As for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 04:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gLPVm-0005cn-6T for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 04:25:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Nov 2018 09:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 33195 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 33195@debbugs.gnu.org, eliz@gnu.org, jtamagnan@gmail.com Original-Received: via spool by 33195-done@debbugs.gnu.org id=D33195.154184189221598 (code D ref 33195); Sat, 10 Nov 2018 09:25:01 +0000 Original-Received: (at 33195-done) by debbugs.gnu.org; 10 Nov 2018 09:24:52 +0000 Original-Received: from localhost ([127.0.0.1]:44157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLPVc-0005cI-Go for submit@debbugs.gnu.org; Sat, 10 Nov 2018 04:24:52 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:38811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLPVa-0005c3-6j for 33195-done@debbugs.gnu.org; Sat, 10 Nov 2018 04:24:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLPVR-0001Jl-Si for 33195-done@debbugs.gnu.org; Sat, 10 Nov 2018 04:24:45 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLPVR-0001Im-C7; Sat, 10 Nov 2018 04:24:41 -0500 Original-Received: from [176.228.60.248] (port=4694 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gLPVP-000296-Rc; Sat, 10 Nov 2018 04:24:40 -0500 In-reply-to: <87tvl3cmrj.fsf@gmail.com> (message from Jules Tamagnan on Tue, 30 Oct 2018 11:28:16 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152240 Archived-At: > From: Jules Tamagnan > Cc: 33195@debbugs.gnu.org > Date: Tue, 30 Oct 2018 11:28:16 -0700 > > I noticed that I had marked GID as optional in the manual, below is a > patch with that fixed. Thanks, I pushed this to the master branch, and I'm closing the bug report. Please note the following nits for the future: . Please include a ChangeLog-style commit log message, which names all the new/modified functions and nodes in the manuals. . Arguments to functions should be tested for validity, to avoid crashes if called with invalid arguments. . The first line a of a doc string should be a complete sentence shorter than 80 characters, so it fits on a single screen line, and it should mention all the mandatory arguments of the function.