From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion Date: Fri, 23 Nov 2018 10:35:02 +0200 Message-ID: <837eh4gpjd.fsf@gnu.org> References: <9B715204-BE6D-4F02-B484-1EA9EDACE0EB@scratch.space> <87wope15gh.fsf@mail.linkov.net> <4D07BB6C-98A9-4EC2-BB37-097D5D753E53@scratch.space> <87wopbzeuy.fsf@mail.linkov.net> <87d0r04tmg.fsf@mail.linkov.net> <87sgzv747k.fsf@mail.linkov.net> <740AF1DA-7EDB-4310-8C6E-F7944D714513@scratch.space> <87sgzuca5o.fsf@mail.linkov.net> <87a7m0hi5t.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1542962049 26771 195.159.176.226 (23 Nov 2018 08:34:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Nov 2018 08:34:09 +0000 (UTC) Cc: van@scratch.space, 33398@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 23 09:34:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQ6uY-0006o3-Qv for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Nov 2018 09:34:02 +0100 Original-Received: from localhost ([::1]:51013 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQ6wf-0008HX-1i for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Nov 2018 03:36:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQ6wY-0008HS-Rr for bug-gnu-emacs@gnu.org; Fri, 23 Nov 2018 03:36:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQ6wU-0003oE-2s for bug-gnu-emacs@gnu.org; Fri, 23 Nov 2018 03:36:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38720) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gQ6wT-0003o3-Vb for bug-gnu-emacs@gnu.org; Fri, 23 Nov 2018 03:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gQ6wT-0003Mx-Pk for bug-gnu-emacs@gnu.org; Fri, 23 Nov 2018 03:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Nov 2018 08:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33398 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33398-submit@debbugs.gnu.org id=B33398.154296210512884 (code B ref 33398); Fri, 23 Nov 2018 08:36:01 +0000 Original-Received: (at 33398) by debbugs.gnu.org; 23 Nov 2018 08:35:05 +0000 Original-Received: from localhost ([127.0.0.1]:42978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQ6vY-0003Lk-Uz for submit@debbugs.gnu.org; Fri, 23 Nov 2018 03:35:05 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:33261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQ6vU-0003L7-VL for 33398@debbugs.gnu.org; Fri, 23 Nov 2018 03:35:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQ6vL-0000Il-3x for 33398@debbugs.gnu.org; Fri, 23 Nov 2018 03:34:55 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQ6vJ-0000DO-FR; Fri, 23 Nov 2018 03:34:50 -0500 Original-Received: from [176.228.60.248] (port=4504 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gQ6vI-000643-NZ; Fri, 23 Nov 2018 03:34:49 -0500 In-reply-to: <87a7m0hi5t.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 23 Nov 2018 00:16:46 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152704 Archived-At: > From: Juri Linkov > Date: Fri, 23 Nov 2018 00:16:46 +0200 > Cc: 33398@debbugs.gnu.org > > The existing hi-blue face's color "light blue" is closer to the existing > lazy-highlight face's color "paleturquoise" than to the new hi-cyan > face's color "DarkSlateGray1" proposed in the patch below, so this > color choice will be better then existing: > > diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el > index 08b58117dd..95d7f867df 100644 > --- a/lisp/hi-lock.el > +++ b/lisp/hi-lock.el > @@ -157,8 +157,11 @@ hi-yellow > :group 'hi-lock-faces) > > (defface hi-pink > - '((((background dark)) (:background "pink" :foreground "black")) > - (t (:background "pink"))) > + '((((min-colors 88) (background dark)) > + (:background "pink" :foreground "black")) > + (((background dark)) (:background "red" :foreground "black")) > + (((min-colors 88)) (:background "pink")) > + (t (:background "red"))) > "Face for hi-lock mode." > :group 'hi-lock-faces) Thanks for working on this, but unfortunately changing the default colors for Emacs faces is not that easy (which is why we do that only very rarely). You cannot test your colors in just two points: 8-color TTY and 256-color display (you probably used a GUI frame?). For starters, there's the 16-color TTY, where according to my testing your changes are for the worse. And I would also suggest to test with a 88-color TTY. You need to test for both dark and light backgrounds. In general, if the automatic color translation in tty-colors.el does a good job (you can test that by specifying the X color and watching the result), it is best not to have a special definition for the corresponding min-colors. So, for example, for the new hi-magenta and hi-cyan faces you introduce, please see whether you really need the definitions for less than 88 colors -- they will only be needed if the automatic translation produces unpleasant results.