From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34256: 27.0.50; Crash on draw_glyphs() Date: Mon, 04 Feb 2019 19:50:50 +0200 Message-ID: <837eefv3wl.fsf@gnu.org> References: <83pnse15pb.fsf@gnu.org> <83k1im142z.fsf@gnu.org> <83bm3y0ycm.fsf@gnu.org> <834l9o2acz.fsf@gnu.org> <83lg30zs5d.fsf@gnu.org> <83ef8szi8i.fsf@gnu.org> <834l9nzys6.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="6007"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34256-done@debbugs.gnu.org To: Kaushal Modi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 04 18:52:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqiPn-0001S2-05 for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Feb 2019 18:52:15 +0100 Original-Received: from localhost ([127.0.0.1]:46768 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqiPm-0001WH-2u for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Feb 2019 12:52:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqiPb-0001W0-DJ for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 12:52:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqiPa-0004Id-Jb for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 12:52:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60413) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqiPa-0004IN-Fq for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 12:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gqiPa-0003Za-Cz for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 12:52:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Feb 2019 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 34256 X-GNU-PR-Package: emacs Mail-Followup-To: 34256@debbugs.gnu.org, eliz@gnu.org, kaushal.modi@gmail.com Original-Received: via spool by 34256-done@debbugs.gnu.org id=D34256.154930267713671 (code D ref 34256); Mon, 04 Feb 2019 17:52:02 +0000 Original-Received: (at 34256-done) by debbugs.gnu.org; 4 Feb 2019 17:51:17 +0000 Original-Received: from localhost ([127.0.0.1]:59693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqiOp-0003YP-Tn for submit@debbugs.gnu.org; Mon, 04 Feb 2019 12:51:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqiOo-0003YD-HK for 34256-done@debbugs.gnu.org; Mon, 04 Feb 2019 12:51:14 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqiOi-0003X0-39; Mon, 04 Feb 2019 12:51:08 -0500 Original-Received: from [176.228.60.248] (port=2738 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gqiOf-0007YK-Lf; Mon, 04 Feb 2019 12:51:08 -0500 In-reply-to: (message from Kaushal Modi on Mon, 4 Feb 2019 11:03:37 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155085 Archived-At: > From: Kaushal Modi > Date: Mon, 4 Feb 2019 11:03:37 -0500 > Cc: 34256@debbugs.gnu.org > > Thanks for the patch! > > I couldn't apply the patch, so had to apply it manually. > > But it works! Thanks, I've now pushed it to the master branch. > I am looking forward to understand in plain terms what this fix did. What happened was that while the display engine was redisplaying the buffer, font-lock was called to fontify some part of the buffer, and that activated Org mode (because the buffer displayed diffs of an Org file, I presume?), and Org mode explicitly clears the image cache of the frame for some reason I couldn't fathom. So an inline image that was ready to be displayed got removed and freed from under the feet of the display engine, and when the time came to actually display it, there was nothing to display... The fix is to inhibit clearing of a frame's image cache until after the frame has been updated by the display engine. Thanks for helping me track this bug.