From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36157: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff Date: Mon, 10 Jun 2019 18:37:07 +0300 Message-ID: <837e9tbgf0.fsf@gnu.org> References: <878su9tv4x.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="151236"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36157@debbugs.gnu.org, kaushal.modi@gmail.com To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 10 17:38:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1haMNE-000dAM-Nc for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jun 2019 17:38:16 +0200 Original-Received: from localhost ([::1]:47766 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haMND-0004xm-NB for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jun 2019 11:38:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51466) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haMN5-0004uj-TP for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 11:38:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1haMN4-0006N9-62 for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 11:38:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43818) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1haMN0-0006Ko-55 for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 11:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1haMN0-0005NZ-0r for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 11:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jun 2019 15:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36157 X-GNU-PR-Package: emacs Original-Received: via spool by 36157-submit@debbugs.gnu.org id=B36157.156018103820623 (code B ref 36157); Mon, 10 Jun 2019 15:38:01 +0000 Original-Received: (at 36157) by debbugs.gnu.org; 10 Jun 2019 15:37:18 +0000 Original-Received: from localhost ([127.0.0.1]:57360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haMMH-0005MY-KC for submit@debbugs.gnu.org; Mon, 10 Jun 2019 11:37:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haMMG-0005MO-3H for 36157@debbugs.gnu.org; Mon, 10 Jun 2019 11:37:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1haMMA-0005V5-TK; Mon, 10 Jun 2019 11:37:10 -0400 Original-Received: from [176.228.60.248] (port=2784 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1haMM9-0007oe-VX; Mon, 10 Jun 2019 11:37:10 -0400 In-reply-to: <878su9tv4x.fsf@gmail.com> (message from Alex Branham on Mon, 10 Jun 2019 08:41:50 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160329 Archived-At: > From: Alex Branham > Date: Mon, 10 Jun 2019 08:41:50 -0500 > Cc: 36157@debbugs.gnu.org > > > It seems like properly enabling lexical binding in ediff will be a bit > > tricky. > > > > If you look at the code of ediff-find-file, you will see the use of > > `symbol-value' everywhere. > > Indeed, it looks like portions of ediff expect symbols like file-A and > file-B to be dynamically bound, but also passes them through as > arguments to functions. I'm not sure what the best way to deal with this > is, since if we just mark them as special the lexical binding will > shadow the global binding anyway. > > In the meantime, feel free to revert that patch if its causing issues. If there are no ideas how to fix this in a week or so, I suggest to revert the changeset while we consider the possible solutions, and add a comment that converting these files to lexical-binding is hairy. Thanks.