bug#6861: 24.0.50; Scroll lock not bound

bug#6861: 24.0.50; Scroll lock not bound

[David Kastrup]

I tried using the Scroll Lock Key, and got an error telling me it is
unbound.  I figured out there was a library scroll-lock and loaded it.
The Scroll Lock Key still was unbound, though calling scroll-lock-mode
did what I would have expected to be on the scroll lock key.

I suggest putting an appropriate autoloaded default global key
definition on the Scroll Lock Key, since nothing is gained by not
binding it to something useful.  If a user happens to have his own
different definition, this will override the default anyway.


In GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.20.1)
 of 2010-07-12 on lola
Windowing system distributor `The X.Org Foundation', version 11.0.10706000
configured using `configure  '--prefix=/usr/local/emacs' '--without-toolkit-scroll-bars' 'CFLAGS=-O2 -fno-crossjumping -g''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Scheme

Minor modes in effect:
  scroll-lock-mode: t
  diff-auto-refine-mode: t
  global-semanticdb-minor-mode: t
  global-semantic-idle-scheduler-mode: t
  semantic-idle-scheduler-mode: t
  semantic-mode: t
  shell-dirtrack-mode: t
  TeX-PDF-mode: t
  desktop-save-mode: t
  minibuffer-electric-default-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<Scroll_Lock> M-x l o a d - l i <tab> <return> s c 
r o <tab> <tab> l o <tab> <return> <Scroll_Lock> M-x 
s c r o <tab> <tab> l o c <tab> m o <tab> <return> 
<Scroll_Lock> <up> <up> <down> <down> <down> <up> M-x 
r e p o r t - e m <tab> <return>

Recent messages:
Loading scroll-lock...done
Making completion list...
Scroll-Lock mode enabled

Load-path shadows:
None found.

Features:
(shadow emacsbug scroll-lock ispell rect diff-mode semantic/tag-file
jka-compr semantic/tag-write semantic/bovine semantic/wisent/python
semantic/wisent/python-wy semantic/wisent semantic/wisent/wisent
semantic/bovine/scm semantic/bovine/scm-by semantic/db-file cedet-files
semantic/bovine/c semantic/decorate/include semantic/db-find
semantic/db-ref semantic/decorate/mode semantic/decorate pulse
semantic/bovine/c-by semantic/lex-spp semantic/bovine/gcc semantic/dep
semantic/analyze semantic/sort semantic/scope semantic/analyze/fcn
semantic/db-mode semantic/db eieio-base semantic/idle semantic/format
ezimage semantic/tag-ls semantic/ctxt semantic/util-modes semantic/util
semantic semantic/tag semantic/lex semantic/fw eieio mode-local cedet pp
url-mailto url-auth url url-proxy url-privacy url-expand url-methods
url-history url-cookie gnus-dup dabbrev multi-isearch help-mode view
debug sendmail nndoc tramp-imap assoc tramp-gw tramp-gvfs zeroconf
url-util url-parse url-vars dbus xml tramp-fish tramp-smb tramp-cache
tramp-ftp tramp-cmds tramp shell tramp-compat trampver browse-url
canlock sha1 hex-util newcomment gnus-fun gnus-kill qp sort gnus-cite
smiley ansi-color flow-fill mail-extr gnus-async gnus-bcklg gnus-ml
disp-table nnfolder parse-time timezone nnnil pop3 nnml nndraft nnmh
auth-source netrc gnus-agent gnus-srvr gnus-score score-mode nnvirtual
gnus-msg gnus-art mm-uu mml2015 epg-config mm-view smime password-cache
dig mailcap nntp gnus-cache gnus-mlspl gnus-sum nnoo gnus-group
time-date gnus-undo nnmail mail-source format-spec gnus-start gnus-spec
gnus-int gnus-range gnus-win diary-lib diary-loaddefs cal-menu calendar
cal-loaddefs info sh-script executable dired-x dired-aux dired message
rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader vc-rcs
latexenc preview prv-emacs byte-opt warnings reftex-vcr reftex-dcr
reftex-auc reftex reftex-vars tex-bar toolbar-x noutline outline
font-latex bytecomp byte-compile latex easy-mmode edmacro kmacro
tex-style tex-buf tex-info texinfo tex meta-mode python-21 python
cc-mode cc-fonts cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars
cc-defs vc-git lilypond-mode compile comint regexp-opt ring easymenu
scheme package advice help-fns advice-preload desktop minibuf-eldef gnus
gnus-ems nnheader gnus-util mail-utils mm-util mail-prsvr wid-edit
cus-start cus-load preview-latex tex-site auto-loads server tooltip
ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd
fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer
select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu
font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan
thai tai-viet lao korean japanese hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces
cus-face files text-properties overlay md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote
make-network-process dbusbind dynamic-setting system-font-setting
font-render-setting gtk x-toolkit x multi-tty emacs)

-- 
David Kastrup

bug#6861: 24.0.50; Scroll lock not bound

[Stefan Kangas]

David Kastrup <dak@gnu.org> writes:

> I tried using the Scroll Lock Key, and got an error telling me it is
> unbound.  I figured out there was a library scroll-lock and loaded it.
> The Scroll Lock Key still was unbound, though calling scroll-lock-mode
> did what I would have expected to be on the scroll lock key.
>
> I suggest putting an appropriate autoloaded default global key
> definition on the Scroll Lock Key, since nothing is gained by not
> binding it to something useful.  If a user happens to have his own
> different definition, this will override the default anyway.

That sounds reasonable to me.  It should be a small job to do it.
Does anyone disagree with such a change?

Thanks,
Stefan Kangas

bug#6861: 24.0.50; Scroll lock not bound

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]

Stefan Kangas <stefan@marxist.se> writes:

> David Kastrup <dak@gnu.org> writes:
>
>> I tried using the Scroll Lock Key, and got an error telling me it is
>> unbound.  I figured out there was a library scroll-lock and loaded it.
>> The Scroll Lock Key still was unbound, though calling scroll-lock-mode
>> did what I would have expected to be on the scroll lock key.
>>
>> I suggest putting an appropriate autoloaded default global key
>> definition on the Scroll Lock Key, since nothing is gained by not
>> binding it to something useful.  If a user happens to have his own
>> different definition, this will override the default anyway.
>
> That sounds reasonable to me.  It should be a small job to do it.
> Does anyone disagree with such a change?

If there are no objections, I'll install the attached patch in a couple of days.
I've also included a NEWS entry for this change.

Thanks,
Stefan Kangas

[-- Attachment #2: 0001-Bind-Scroll-Lock-to-scroll-lock-mode-globally.patch --]
[-- Type: text/x-patch, Size: 901 bytes --]

From 5c299e9886333e606c4300debd9f6363c7d60791 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Tue, 20 Aug 2019 19:04:16 +0200
Subject: [PATCH] Bind Scroll Lock to scroll-lock-mode globally

* lisp/bindings.el (global-map): Bind Scroll_Lock to
scroll-lock-mode.  (Bug#6861)
---
 lisp/bindings.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/bindings.el b/lisp/bindings.el
index 0be1458798..16da2bdf9a 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -1054,6 +1054,7 @@ global-map
 ;(define-key global-map [delete] 'backward-delete-char)
 
 ;; natural bindings for terminal keycaps --- defined in X keysym order
+(define-key global-map [Scroll_Lock]    'scroll-lock-mode)
 (define-key global-map [C-S-backspace]  'kill-whole-line)
 (define-key global-map [home]		'move-beginning-of-line)
 (define-key global-map [C-home]		'beginning-of-buffer)
-- 
2.20.1

bug#6861: 24.0.50; Scroll lock not bound

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 20 Aug 2019 19:15:34 +0200
> Cc: 6861@debbugs.gnu.org
> 
> > David Kastrup <dak@gnu.org> writes:
> >
> >> I tried using the Scroll Lock Key, and got an error telling me it is
> >> unbound.  I figured out there was a library scroll-lock and loaded it.
> >> The Scroll Lock Key still was unbound, though calling scroll-lock-mode
> >> did what I would have expected to be on the scroll lock key.
> >>
> >> I suggest putting an appropriate autoloaded default global key
> >> definition on the Scroll Lock Key, since nothing is gained by not
> >> binding it to something useful.  If a user happens to have his own
> >> different definition, this will override the default anyway.
> >
> > That sounds reasonable to me.  It should be a small job to do it.
> > Does anyone disagree with such a change?
> 
> If there are no objections, I'll install the attached patch in a couple of days.

What about w32-scroll-lock-modifier?

bug#6861: 24.0.50; Scroll lock not bound

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

> > If there are no objections, I'll install the attached patch in a couple of days.
>
> What about w32-scroll-lock-modifier?

I'm unfortunately not familiar with that at all, since I never use
Windows.  Nor do I currently have access to any Windows boxes for
testing.  Would this patch break something on w32, or would it just
not work there?

Thanks,
Stefan Kangas

bug#6861: 24.0.50; Scroll lock not bound

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 20 Aug 2019 20:28:15 +0200
> Cc: David Kastrup <dak@gnu.org>, 6861@debbugs.gnu.org
> 
> > What about w32-scroll-lock-modifier?
> 
> I'm unfortunately not familiar with that at all, since I never use
> Windows.  Nor do I currently have access to any Windows boxes for
> testing.  Would this patch break something on w32, or would it just
> not work there?

It might not work if w32-scroll-lock-modifier was customized to have
ScrollLock act as a modifier key.

bug#6861: 24.0.50; Scroll lock not bound

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

> > > What about w32-scroll-lock-modifier?
> >
> > I'm unfortunately not familiar with that at all, since I never use
> > Windows.  Nor do I currently have access to any Windows boxes for
> > testing.  Would this patch break something on w32, or would it just
> > not work there?
>
> It might not work if w32-scroll-lock-modifier was customized to have
> ScrollLock act as a modifier key.

Could someone with access to a Windows machine please test this patch?

Thanks,
Stefan Kangas

bug#6861: 24.0.50; Scroll lock not bound

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 27 Aug 2019 14:28:30 +0200
> Cc: David Kastrup <dak@gnu.org>, 6861@debbugs.gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > > > What about w32-scroll-lock-modifier?
> > >
> > > I'm unfortunately not familiar with that at all, since I never use
> > > Windows.  Nor do I currently have access to any Windows boxes for
> > > testing.  Would this patch break something on w32, or would it just
> > > not work there?
> >
> > It might not work if w32-scroll-lock-modifier was customized to have
> > ScrollLock act as a modifier key.
> 
> Could someone with access to a Windows machine please test this patch?

I can, but I'm not sure I understand what you'd like to test.  With
the default value of w32-scroll-lock-modifier your patch will
definitely work; with w32-scroll-lock-modifier customized to some
modifier, like 'super, it will certainly NOT work.

So I think we need to tell Windows users that this binding won't work
if w32-scroll-lock-modifier was customized to a n on-nil value.  Any
suggestions for where to document that?

bug#6861: 24.0.50; Scroll lock not bound

[David Kastrup]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Stefan Kangas <stefan@marxist.se>
>> Date: Tue, 27 Aug 2019 14:28:30 +0200
>> Cc: David Kastrup <dak@gnu.org>, 6861@debbugs.gnu.org
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> > > > What about w32-scroll-lock-modifier?
>> > >
>> > > I'm unfortunately not familiar with that at all, since I never use
>> > > Windows.  Nor do I currently have access to any Windows boxes for
>> > > testing.  Would this patch break something on w32, or would it just
>> > > not work there?
>> >
>> > It might not work if w32-scroll-lock-modifier was customized to have
>> > ScrollLock act as a modifier key.
>> 
>> Could someone with access to a Windows machine please test this patch?
>
> I can, but I'm not sure I understand what you'd like to test.  With
> the default value of w32-scroll-lock-modifier your patch will
> definitely work; with w32-scroll-lock-modifier customized to some
> modifier, like 'super, it will certainly NOT work.
>
> So I think we need to tell Windows users that this binding won't work
> if w32-scroll-lock-modifier was customized to a n on-nil value.  Any
> suggestions for where to document that?

According to Git's logs, w32-scroll-lock-modifier keyboard support was
apparently originally contributed by Geoff Voelker in 1999 (he has not
been active since that year) and subsequently maintained and documented
by you (last documentation changes in 2016).  For better or worse, that
probably makes you by far the best candidate for documenting (and/or
possibly even for fixing) the interactions of w32-scroll-lock-modifier
with default activations of the Scroll Lock keybindings on non-Windows
systems.

-- 
David Kastrup

bug#6861: 24.0.50; Scroll lock not bound

[Eli Zaretskii]

> From: David Kastrup <dak@gnu.org>
> Cc: Stefan Kangas <stefan@marxist.se>,  6861@debbugs.gnu.org
> Date: Tue, 27 Aug 2019 15:00:36 +0200
> 
> According to Git's logs, w32-scroll-lock-modifier keyboard support was
> apparently originally contributed by Geoff Voelker in 1999 (he has not
> been active since that year) and subsequently maintained and documented
> by you (last documentation changes in 2016).  For better or worse, that
> probably makes you by far the best candidate for documenting (and/or
> possibly even for fixing) the interactions of w32-scroll-lock-modifier
> with default activations of the Scroll Lock keybindings on non-Windows
> systems.

What if the best candidate doesn't necessarily have time for doing
everything for which he/she is the best candidate?  Does the best
candidate then get to be able to ask someone else to do it?

bug#6861: 24.0.50; Scroll lock not bound

[David Kastrup]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: David Kastrup <dak@gnu.org>
>> Cc: Stefan Kangas <stefan@marxist.se>,  6861@debbugs.gnu.org
>> Date: Tue, 27 Aug 2019 15:00:36 +0200
>> 
>> According to Git's logs, w32-scroll-lock-modifier keyboard support was
>> apparently originally contributed by Geoff Voelker in 1999 (he has not
>> been active since that year) and subsequently maintained and documented
>> by you (last documentation changes in 2016).  For better or worse, that
>> probably makes you by far the best candidate for documenting (and/or
>> possibly even for fixing) the interactions of w32-scroll-lock-modifier
>> with default activations of the Scroll Lock keybindings on non-Windows
>> systems.
>
> What if the best candidate doesn't necessarily have time for doing
> everything for which he/she is the best candidate?  Does the best
> candidate then get to be able to ask someone else to do it?

Nobody gets to ask someone else to do anything regarding free software
unless paying them for it.  In the end, that means that most features
and ports get maintained by those interested in the particular port
and/or feature.

The quality of the Windows port, like all ports, stands and falls with
the interest of those investing time and energy into it.  Blocking
useful features for free platforms because of interference with
non-standard settings of Windows-only special features is something that
does not make a lot of sense within the frame of the GNU project.

If you have a concrete proposal of what to do better other than "don't
touch this code", based on your relative acquaintance with it, that
would likely go a long way towards keeping things running also on W32.

-- 
David Kastrup

bug#6861: 24.0.50; Scroll lock not bound

[Eli Zaretskii]

> From: David Kastrup <dak@gnu.org>
> Cc: stefan@marxist.se,  6861@debbugs.gnu.org
> Date: Tue, 27 Aug 2019 21:11:39 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: David Kastrup <dak@gnu.org>
> >> Cc: Stefan Kangas <stefan@marxist.se>,  6861@debbugs.gnu.org
> >> Date: Tue, 27 Aug 2019 15:00:36 +0200
> >> 
> >> According to Git's logs, w32-scroll-lock-modifier keyboard support was
> >> apparently originally contributed by Geoff Voelker in 1999 (he has not
> >> been active since that year) and subsequently maintained and documented
> >> by you (last documentation changes in 2016).  For better or worse, that
> >> probably makes you by far the best candidate for documenting (and/or
> >> possibly even for fixing) the interactions of w32-scroll-lock-modifier
> >> with default activations of the Scroll Lock keybindings on non-Windows
> >> systems.
> >
> > What if the best candidate doesn't necessarily have time for doing
> > everything for which he/she is the best candidate?  Does the best
> > candidate then get to be able to ask someone else to do it?
> 
> Nobody gets to ask someone else to do anything regarding free software
> unless paying them for it.  In the end, that means that most features
> and ports get maintained by those interested in the particular port
> and/or feature.
> 
> The quality of the Windows port, like all ports, stands and falls with
> the interest of those investing time and energy into it.  Blocking
> useful features for free platforms because of interference with
> non-standard settings of Windows-only special features is something that
> does not make a lot of sense within the frame of the GNU project.
> 
> If you have a concrete proposal of what to do better other than "don't
> touch this code", based on your relative acquaintance with it, that
> would likely go a long way towards keeping things running also on W32.

You've made a huge mountain out of a molehill.  All I did was review a
patch and provide comments to make it better.

bug#6861: 24.0.50; Scroll lock not bound

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

> > Could someone with access to a Windows machine please test this patch?
>
> I can, but I'm not sure I understand what you'd like to test.  With
> the default value of w32-scroll-lock-modifier your patch will
> definitely work; with w32-scroll-lock-modifier customized to some
> modifier, like 'super, it will certainly NOT work.

Got it.

> So I think we need to tell Windows users that this binding won't work
> if w32-scroll-lock-modifier was customized to a n on-nil value.  Any
> suggestions for where to document that?

I'm not so sure what would be a good place to do it.  For starters, I
can't find any reference to w32-scroll-lock-modifier in the manual,
and I'm not sure if that's on purpose.

To my mind, it would be enough to add it to the NEWS entry.
Alternatively, we could add a section on scroll-lock-mode to (info
"(emacs) Auto Scrolling") and document it there.  (Although I'm not
sure it makes sense given that w32-scroll-lock-modifier is not
mentioned anywhere else...)

WDYT?

Best regards,
Stefan Kangas

bug#6861: 24.0.50; Scroll lock not bound

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Thu, 26 Sep 2019 19:47:50 +0200
> Cc: David Kastrup <dak@gnu.org>, 6861@debbugs.gnu.org
> 
> > So I think we need to tell Windows users that this binding won't work
> > if w32-scroll-lock-modifier was customized to a n on-nil value.  Any
> > suggestions for where to document that?
> 
> I'm not so sure what would be a good place to do it.  For starters, I
> can't find any reference to w32-scroll-lock-modifier in the manual,
> and I'm not sure if that's on purpose.

Try the other manual, emacs.info.

> To my mind, it would be enough to add it to the NEWS entry.

I think it should be in the doc string of that mode as well.

Thanks.

bug#6861: 24.0.50; Scroll lock not bound

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> > > So I think we need to tell Windows users that this binding won't work
> > > if w32-scroll-lock-modifier was customized to a n on-nil value.  Any
> > > suggestions for where to document that?
> >
> > I'm not so sure what would be a good place to do it.  For starters, I
> > can't find any reference to w32-scroll-lock-modifier in the manual,
> > and I'm not sure if that's on purpose.
>
> Try the other manual, emacs.info.

Thanks, found it now.  Not sure how I missed it before.

> > To my mind, it would be enough to add it to the NEWS entry.
>
> I think it should be in the doc string of that mode as well.

OK.  How about the attached patch?

Best regards,
Stefan Kangas

[-- Attachment #2: 0001-Bind-Scroll_Lock-to-scroll-lock-mode-globally.patch --]
[-- Type: text/x-patch, Size: 2245 bytes --]

From 9eb8299d476da6cf190985394c37331c9f5ee224 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Tue, 20 Aug 2019 19:04:16 +0200
Subject: [PATCH] Bind Scroll_Lock to scroll-lock-mode globally

* lisp/bindings.el (global-map): Bind Scroll_Lock to
scroll-lock-mode.  (Bug#6861)
* lisp/scroll-lock.el (scroll-lock-mode): Note that the binding will
not work if 'w32-scroll-lock-modifier' is non-nil.
* etc/NEWS: Announce it.
---
 etc/NEWS            | 5 +++++
 lisp/bindings.el    | 1 +
 lisp/scroll-lock.el | 5 ++++-
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/etc/NEWS b/etc/NEWS
index 56e5fd2f83..f67da0cbbe 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -419,6 +419,11 @@ RGB triplets with a single hexadecimal digit per component.
 ---
 ** The toolbar now shows the equivalent key binding in its tooltips.
 
+---
+** 'scroll-lock-mode' is now bound to the 'Scroll_Lock' key globally.
+Note that this key binding will not work on Windows systems if
+'w32-scroll-lock-modifier' is non-nil.
+
 \f
 * Editing Changes in Emacs 27.1
 
diff --git a/lisp/bindings.el b/lisp/bindings.el
index 0be1458798..16da2bdf9a 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -1054,6 +1054,7 @@ global-map
 ;(define-key global-map [delete] 'backward-delete-char)
 
 ;; natural bindings for terminal keycaps --- defined in X keysym order
+(define-key global-map [Scroll_Lock]    'scroll-lock-mode)
 (define-key global-map [C-S-backspace]  'kill-whole-line)
 (define-key global-map [home]		'move-beginning-of-line)
 (define-key global-map [C-home]		'beginning-of-buffer)
diff --git a/lisp/scroll-lock.el b/lisp/scroll-lock.el
index 3a74c11b7a..d84d13564a 100644
--- a/lisp/scroll-lock.el
+++ b/lisp/scroll-lock.el
@@ -54,7 +54,10 @@ scroll-lock-mode
 When enabled, keys that normally move point by line or paragraph
 will scroll the buffer by the respective amount of lines instead
 and point will be kept vertically fixed relative to window
-boundaries during scrolling."
+boundaries during scrolling.
+
+Note that the default key binding to Scroll_Lock will not work on
+Windows systems if `w32-scroll-lock-modifier' is non-nil."
   :lighter " ScrLck"
   :keymap scroll-lock-mode-map
   (if scroll-lock-mode
-- 
2.20.1

bug#6861: 24.0.50; Scroll lock not bound

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Sat, 28 Sep 2019 13:26:48 +0200
> Cc: David Kastrup <dak@gnu.org>, 6861@debbugs.gnu.org
> 
> > > To my mind, it would be enough to add it to the NEWS entry.
> >
> > I think it should be in the doc string of that mode as well.
> 
> OK.  How about the attached patch?

It's fine, but please say "MS-Windows" to be more precise.

Thanks.

bug#6861: 24.0.50; Scroll lock not bound

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> > OK.  How about the attached patch?
>
> It's fine, but please say "MS-Windows" to be more precise.

Thanks; fixed in attached patch.  I'll push it in a couple of days if
there are no further comments.

Best regards,
Stefan Kangas

[-- Attachment #2: 0001-Bind-Scroll_Lock-to-scroll-lock-mode-globally.patch --]
[-- Type: text/x-patch, Size: 2251 bytes --]

From 4e45ae74bffd9c4f8ff8427eb4c41cfee167b3f1 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Tue, 20 Aug 2019 19:04:16 +0200
Subject: [PATCH] Bind Scroll_Lock to scroll-lock-mode globally

* lisp/bindings.el (global-map): Bind Scroll_Lock to
scroll-lock-mode.  (Bug#6861)
* lisp/scroll-lock.el (scroll-lock-mode): Note that the binding will
not work if 'w32-scroll-lock-modifier' is non-nil.
* etc/NEWS: Announce it.
---
 etc/NEWS            | 5 +++++
 lisp/bindings.el    | 1 +
 lisp/scroll-lock.el | 5 ++++-
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/etc/NEWS b/etc/NEWS
index 56e5fd2f83..60b583200a 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -419,6 +419,11 @@ RGB triplets with a single hexadecimal digit per component.
 ---
 ** The toolbar now shows the equivalent key binding in its tooltips.
 
+---
+** 'scroll-lock-mode' is now bound to the 'Scroll_Lock' key globally.
+Note that this key binding will not work on MS-Windows systems if
+'w32-scroll-lock-modifier' is non-nil.
+
 \f
 * Editing Changes in Emacs 27.1
 
diff --git a/lisp/bindings.el b/lisp/bindings.el
index 0be1458798..16da2bdf9a 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -1054,6 +1054,7 @@ global-map
 ;(define-key global-map [delete] 'backward-delete-char)
 
 ;; natural bindings for terminal keycaps --- defined in X keysym order
+(define-key global-map [Scroll_Lock]    'scroll-lock-mode)
 (define-key global-map [C-S-backspace]  'kill-whole-line)
 (define-key global-map [home]		'move-beginning-of-line)
 (define-key global-map [C-home]		'beginning-of-buffer)
diff --git a/lisp/scroll-lock.el b/lisp/scroll-lock.el
index 3a74c11b7a..36e2264fe4 100644
--- a/lisp/scroll-lock.el
+++ b/lisp/scroll-lock.el
@@ -54,7 +54,10 @@ scroll-lock-mode
 When enabled, keys that normally move point by line or paragraph
 will scroll the buffer by the respective amount of lines instead
 and point will be kept vertically fixed relative to window
-boundaries during scrolling."
+boundaries during scrolling.
+
+Note that the default key binding to Scroll_Lock will not work on
+MS-Windows systems if `w32-scroll-lock-modifier' is non-nil."
   :lighter " ScrLck"
   :keymap scroll-lock-mode-map
   (if scroll-lock-mode
-- 
2.20.1

bug#6861: 24.0.50; Scroll lock not bound

[Stefan Kangas]

close 6861 27.1
quit

> I'll push it in a couple of days if there are no further comments.

Now pushed as commit 591c8bc70f.

Best regards,
Stefan Kangas