From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37785: [PATCH] Add a way to disable substitution of command keys in help strings Date: Thu, 17 Oct 2019 17:06:49 +0300 Message-ID: <837e53bh52.fsf@gnu.org> References: <7a45908a-cc9a-277b-53ea-933756e0e067@gmail.com> <936c65e4-d49b-33da-ad5a-ba854c0df1ff@gmail.com> <83h847bjl5.fsf@gnu.org> <1eecb79e-3087-8c49-5c80-d8a7f619a157@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="89572"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rpluim@gmail.com, 37785@debbugs.gnu.org To: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 17 17:07:02 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iL7Mj-000N7b-W8 for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Oct 2019 17:07:02 +0200 Original-Received: from localhost ([::1]:50338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL7Mi-0000lg-Bb for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Oct 2019 11:07:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43123) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL6Rf-0002Ql-P9 for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 10:08:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iL6Re-000744-N3 for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 10:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iL6Re-000740-Jp for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 10:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iL6Re-0005tJ-BN for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 10:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Oct 2019 14:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37785-submit@debbugs.gnu.org id=B37785.157132123322592 (code B ref 37785); Thu, 17 Oct 2019 14:08:02 +0000 Original-Received: (at 37785) by debbugs.gnu.org; 17 Oct 2019 14:07:13 +0000 Original-Received: from localhost ([127.0.0.1]:48589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL6Qr-0005sK-Bi for submit@debbugs.gnu.org; Thu, 17 Oct 2019 10:07:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL6Qp-0005s8-H3 for 37785@debbugs.gnu.org; Thu, 17 Oct 2019 10:07:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iL6Qk-0006o4-Aw; Thu, 17 Oct 2019 10:07:06 -0400 Original-Received: from [176.228.60.248] (port=3306 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iL6Qj-0006Xa-NX; Thu, 17 Oct 2019 10:07:06 -0400 In-reply-to: <1eecb79e-3087-8c49-5c80-d8a7f619a157@gmail.com> (message from =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel on Thu, 17 Oct 2019 09:47:52 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169582 Archived-At: > Cc: rpluim@gmail.com, 37785@debbugs.gnu.org > From: Clément Pit-Claudel > Date: Thu, 17 Oct 2019 09:47:52 -0400 > > > But show-help-function is for showing help-echo, is it not? > > That's true, and my explanation wasn't very good. I'm working off of this commit: > > commit 5f5fe275ec54194a9293690ffee3d425026ac14b > Author: Paul Eggert > Date: Sun Aug 2 14:55:15 2015 -0700 > > Treat help strings like other doc strings > > * doc/lispref/text.texi (Special Properties), etc/NEWS: Document this. > * lisp/epa.el (epa--select-keys): Remove no-longer-needed calls to > substitute-command-keys. > * src/keyboard.c (show_help_echo, parse_menu_item): Call > substitute-command-keys on the help string before displaying it. > > It adds Fsubstitute_command_keys in two places: show_help_echo and parse_menu_item. The patch I sent makes both of these calls conditional, so calling the variable help-echo-inhibit-substitutions isn't right. Why isn't it right for parse_menu_item? That function uses the :help text, which is help-echo for menu items. > I can either: > * Change the name to something like help-string-inhibit-substitutions. > * Restrict the patch to the argument of show-help-function, and rename the variable to help-echo-inhibit-substitutions. Let's first agree whether or not parse_menu_item triggers help-echo. If you think it doesn't please elaborate as to why you think so. Thanks.