unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 37700@debbugs.gnu.org, tkk@misasa.okayama-u.ac.jp,
	homeros.misasa@gmail.com, monnier@iro.umontreal.ca
Subject: bug#37700: 27.0.50; undo mouse-drag-and-drop-region ineffective
Date: Thu, 31 Oct 2019 18:10:12 +0200	[thread overview]
Message-ID: <837e4kopzv.fsf@gnu.org> (raw)
In-Reply-To: <4E95A327-1B10-46FA-B08F-1877417230A8@acm.org> (message from Mattias Engdegård on Thu, 31 Oct 2019 17:04:41 +0100)

> From: Mattias Engdegård <mattiase@acm.org>
> Date: Thu, 31 Oct 2019 17:04:41 +0100
> Cc: monnier@iro.umontreal.ca, 37700@debbugs.gnu.org,
>         tkk@misasa.okayama-u.ac.jp, homeros.misasa@gmail.com
> 
> > Fine with me (I proposed something like this during the original
> > discussion), but please document this property in the ELisp manual.
> 
> Then I apologise for misunderstanding you!

No need to apologize; I was just explaining why I like this patch ;-)

> Attached patch amended with changes to the manual and NEWS.

Thanks.

> --- a/doc/lispref/text.texi
> +++ b/doc/lispref/text.texi
> @@ -1451,6 +1451,12 @@ Undo
>  This function does not bind @code{undo-in-progress}.
>  @end defun
>  
> +Some commands leave the region active after execution in such a way that
> +it interferes with selective undo of that command.  To make @code{undo}
> +ignore the active region when invoked immediately after such a command,
> +set the property @code{undo-inhibit-region} of the command's function
> +symbol to a non-nil value.

Please add here a cross-reference to the other place, where this
property is described.

> +** 'undo' can be made to ignore the active region for a command
> +by setting its 'undo-inhibit-region' symbol property to non-nil.

Instead of "its" I'd use "that command's", because "its" is a bit
ambiguous in this context.





  reply	other threads:[~2019-10-31 16:10 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 11:51 bug#37700: 27.0.50; undo mouse-drag-and-drop-region ineffective Mattias Engdegård
2019-10-11 12:19 ` martin rudalics
2019-10-11 12:51   ` Mattias Engdegård
2019-10-11 14:43     ` Eli Zaretskii
2019-10-11 17:18       ` Mattias Engdegård
2019-10-11 18:36         ` Eli Zaretskii
2019-10-11 18:51           ` Eli Zaretskii
2019-10-12  8:24           ` martin rudalics
2019-10-11 18:57         ` Eli Zaretskii
2019-10-11 18:26     ` martin rudalics
2019-10-11 19:12       ` Eli Zaretskii
2019-10-12  1:55       ` Tak Kunihiro
2019-10-12  8:24         ` martin rudalics
2019-10-12 16:42           ` Mattias Engdegård
2019-10-12 17:17             ` Eli Zaretskii
2019-10-12 17:53               ` Eli Zaretskii
2019-10-16 15:27                 ` Mattias Engdegård
2019-10-26 10:15                   ` Eli Zaretskii
2019-10-28 20:01                   ` Stefan Monnier
2019-10-30 19:09                     ` Mattias Engdegård
2019-10-30 19:56                       ` Stefan Monnier
2019-10-31 11:00                         ` Mattias Engdegård
2019-10-31 14:45                           ` Eli Zaretskii
2019-10-31 16:04                             ` Mattias Engdegård
2019-10-31 16:10                               ` Eli Zaretskii [this message]
2019-10-31 16:47                                 ` Mattias Engdegård
2019-10-11 12:26 ` Eli Zaretskii
2019-10-11 12:53   ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837e4kopzv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=37700@debbugs.gnu.org \
    --cc=homeros.misasa@gmail.com \
    --cc=mattiase@acm.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=tkk@misasa.okayama-u.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).